Skip to content

Conversation

simzzz
Copy link
Contributor

@simzzz simzzz commented Aug 19, 2022

No description provided.

@simzzz
Copy link
Contributor Author

simzzz commented Aug 19, 2022

TODO:

  • Fix te failing test + maybe find a better testing approach
  • Documentation for route
  • Code examples for GetLeafResponse

@elpiel
Copy link
Member

elpiel commented Aug 19, 2022

Also take into account what we've discussed on slack how to set the earner/spender sides.
enum LeafFor { Spender, Earner} and add it to the respective route as an Extension

@simzzz simzzz marked this pull request as ready for review August 29, 2022 12:45
@simzzz simzzz requested a review from elpiel August 29, 2022 12:45
@elpiel elpiel changed the title added get_leaf route + tests GET /v5/channel/:id/get-leaf route + tests Aug 30, 2022
Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look pretty good. A few polishing touches on Errors remain and a few tests regarding:

  • no ApproveState - 404
  • no NewState (but has approvestate) - 400
  • no spender/earner - you could use the same address and call the function twice

@simzzz simzzz merged commit 8041ec5 into aip-61-adex-v5 Aug 31, 2022
@elpiel elpiel deleted the get-leaf-route branch August 31, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants