add title= kwarg to fast_app() constructor #740
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Propose changes to the codebase
title: '[PR] allow default title to be set from fast_app()'
labels: ''
assignees: ''
Related Issue
Please link to the issue that this pull request addresses. If there isn't one, please create an issue first.
#485
(#604)
Proposed Changes
This PR would add a
title=
kwarg to thefast_app()
constructor, and have the effect of allowing a default page title to be set. It needn't do very much, because the underlying functionality was added toFastHTML()
in #604 ; this PR just connects them.Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Checklist
Go over all the following points, and put an
x
in all the boxes that apply:Additional Information
title='hello'
to the example from the docs here: https://www.fastht.ml/docs/#usagetitle:str="FastHTML page"
I have repeated that default fromFastHTML()
. This seemed simpler/less intrusive than declaringtitle:Optional[str]=None
, and handling it downstream to avoid the DRY.fast_app
call appears to exist outside the nbdev subset, and so if I'm not mistaken there it is appropriate to edit the python code in place.