Fix recognition of errors for dbrestore with postgresql #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psql will always terminate with an exit value of 0 regardless of SQL errors during restore. Setting ON_ERROR_STOP=on fixes this.
This was referenced Sep 14, 2016
|
@patrickhallen |
|
Sorry for my latency and thanks again ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
psql will always terminate with an exit value of 0 regardless of SQL
errors during restore. Setting ON_ERROR_STOP=on fixes this.
This doesn't change the actual behavior of psql as long as --single-transaction is enabled (which is the current default). Without ON_ERROR_STOP and without --single-transaction psql would try to execute the rest of the SQL file and exit succesfully regardless of the number of errors.