Skip to content

Hooks/AlwaysReturnInFilter: adjust expectations for a test #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Hooks/AlwaysReturnInFilter: adjust expectations for a test #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WordPressVIPMinimum/Tests/Hooks/AlwaysReturnInFilterUnitTest.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ class tokenizer_bug_test {
add_filter( 'tokenizer_bug', [ $this, 'tokenizer_bug' ] );
}

public function tokenizer_bug( $param ): namespace\Foo {} // Ok (tokenizer bug in PHPCS < 3.5.7/3.6.0).
public function tokenizer_bug( $param ): namespace\Foo {} // Ok (tokenizer bug PHPCS < 3.5.7) / Error in PHPCS >= 3.5.7.
}

// Intentional parse error. This has to be the last test in the file!
Expand Down
3 changes: 3 additions & 0 deletions WordPressVIPMinimum/Tests/Hooks/AlwaysReturnInFilterUnitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@

namespace WordPressVIPMinimum\Tests\Hooks;

use PHP_CodeSniffer\Config;
use PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest;

/**
* Unit test class for the Hooks/AlwaysReturn sniff.
*
Expand All @@ -31,6 +33,7 @@ public function getErrorList() {
105 => 1,
129 => 1,
163 => 1,
188 => version_compare( Config::VERSION, '3.5.7', '>=' ) ? 1 : 0,
];
}

Expand Down