-
Notifications
You must be signed in to change notification settings - Fork 823
Forms: Update on submit to use new feedback class. #44489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Replaces direct form data extraction with Feedback class methods for retrieving compiled fields, deprecates the $form parameter in several methods, and updates internal logic to use the new approach. This streamlines data handling, improves maintainability, and prepares for future removal of deprecated parameters.
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 1 file.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked well!
This PR update the form submission data to use the new Feedback class.
This PR breaks #44462 into smaller more testable pieces.
Proposed changes:
Other information:
Does this pull request change what data or activity we track or use?
No
Testing instructions:
add_filter( 'jetpack_forms_enable_ajax_submission', '__return_true' );
filter. Notice that it still works as expected.