Skip to content

types: make _id required on Document type #14735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2024
Merged

types: make _id required on Document type #14735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/types/docArray.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ async function gh13424() {
const TestModel = model('Test', testSchema);

const doc = new TestModel();
expectType<Types.ObjectId | undefined>(doc.subDocArray[0]._id);
expectType<Types.ObjectId>(doc.subDocArray[0]._id);
}

async function gh14367() {
Expand Down
2 changes: 1 addition & 1 deletion test/types/schema.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1386,7 +1386,7 @@ function gh13424() {
const TestModel = model('TestModel', new Schema(testSchema));

const doc = new TestModel({});
expectType<Types.ObjectId | undefined>(doc.subDocArray[0]._id);
expectType<Types.ObjectId>(doc.subDocArray[0]._id);
}

function gh14147() {
Expand Down
2 changes: 1 addition & 1 deletion types/document.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ declare module 'mongoose' {
constructor(doc?: any);

/** This documents _id. */
_id?: T;
_id: T;

/** This documents __v. */
__v?: any;
Expand Down