Add M1 prebuilds #2245
Closed
Add M1 prebuilds #2245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I don’t think it could be this easy because all of the dependencies have to be in the right architecture too. |
Author
|
Ah, true... Is the most realistic option here to get a Mac mini, and add that as a self-hosted runner? At least until GitHub offers M-chip hosted runners? I have a downstream project that is very much stuck on the lack of prebuild M1 binaries here, and it might be the easiest for me to just get a Mac mini and (if you are ok with that) connect it to this repo here? |
|
Any clue on how this could be picked up again? Is this something anyone can do? |
|
This should be possible now that GitHub offers Apple silicon runners, right? |
zbjornson
force-pushed
the
prebuilds
branch
7 times, most recently
from
e9c5286 to
8b238be
Compare
2 tasks
Collaborator
|
Merged @jamesbvaughan's PR, so this is obsolete. Thanks for the effort anyways! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea whether this will work, but maybe worth a try? I don't have a M1, so I can't even test this :)
But it does build something when I run the workflow on my fork, and the compiler log has output that suggests it is actually building an arm64 version. The upload step fails in my fork, and I am not familiar enough with that to fix this. Maybe a maintainer here could test things and see whether this might actually be producing the correct binaries?