Skip to content

[DO NOT MERGE] Test SKIP_CERTIFICATE_DOWNLOAD #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: stu-631-studio-blueprints-playground-cli-start-and-stopping-sites
Choose a base branch
from

Conversation

iangmaia
Copy link
Contributor

Testing SKIP_CERTIFICATE_DOWNLOAD variable.

@iangmaia iangmaia self-assigned this Jul 25, 2025
@iangmaia iangmaia force-pushed the iangmaia/631-ci-fix-test branch 2 times, most recently from f39ea50 to ea72ee7 Compare July 25, 2025 11:43
Base automatically changed from iangmaia/631-ci-fix to stu-631-studio-blueprints-playground-cli-start-and-stopping-sites July 25, 2025 11:51
@iangmaia iangmaia force-pushed the iangmaia/631-ci-fix-test branch from ea72ee7 to 803b678 Compare July 25, 2025 13:46
@iangmaia iangmaia force-pushed the iangmaia/631-ci-fix-test branch from 803b678 to dbeb27c Compare July 25, 2025 13:48
@iangmaia
Copy link
Contributor Author

@AliSoftware re: skipping certificates download. I've tested it here and it worked!

See the builds:

Not downloading them still had the tests passing (🎉), though downloading them is very fast so we don't save a lot of time not downloading them. Perhaps it's worth it to still skip the download, but regardless it was a nice "TIL" moment 🙂

@AliSoftware
Copy link
Contributor

Nice! It's good to have confirmation they're not needed for tests 🙂

I think at some point it'd make sense to separate the cert download in its own .ps1, and have it called from prepare_windows_host… unless -SkipDownloadCertificate switch is set etc… if only for consistency and clear separation of concerns/responsibilities in our toolkit scripts, and for the (admittedly very limited) slight improved security of not having such secrets on the machine if not necessary, more than for the ridiculous time it'd save.

But all that could also be a Linear issue for later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants