Skip to content

Build Docker Container for the .NET Sample #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Jun 19, 2020
Merged

Build Docker Container for the .NET Sample #33

merged 17 commits into from
Jun 19, 2020

Conversation

@wenhzha
Copy link
Contributor

@wenhzha wenhzha commented Jun 4, 2020

#3 Add the build docker container step for the dotnet sample

@wenhzha wenhzha requested a review from amanbha June 4, 2020 02:02
ConnorMcMahon
ConnorMcMahon approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@ConnorMcMahon ConnorMcMahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: let's just remove the nupkg and add that file extension to the .gitignore.

@wenhzha wenhzha merged commit a53eed3 into master Jun 19, 2020
@amanbha amanbha deleted the build-container branch June 21, 2020 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amanbha amanbha Awaiting requested review from amanbha

1 more reviewer

@ConnorMcMahon ConnorMcMahon ConnorMcMahon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wenhzha @ConnorMcMahon