Skip to content

Python sample #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 18, 2020
Merged

Python sample #40

merged 14 commits into from
Jun 18, 2020

Conversation

@wenhzha
Copy link
Contributor

@wenhzha wenhzha commented Jun 16, 2020

#3 Adding python sample

fix the non dotnet binding issue

refactor the common component files and update the doc to use the latest dapr cli

@wenhzha wenhzha requested a review from ConnorMcMahon June 16, 2020 21:39
@jeffhollan jeffhollan mentioned this pull request Jun 18, 2020
Closed
ConnorMcMahon
ConnorMcMahon reviewed Jun 18, 2020
View reviewed changes
Copy link
Contributor

@ConnorMcMahon ConnorMcMahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking mostly good. Just making sure all files are necessary, and to see if we require parsing the input parameters from the triggers with json.loads()

ConnorMcMahon
ConnorMcMahon approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@ConnorMcMahon ConnorMcMahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wenhzha wenhzha merged commit 1416104 into master Jun 18, 2020
@wenhzha wenhzha deleted the python-sample branch June 18, 2020 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ConnorMcMahon ConnorMcMahon ConnorMcMahon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wenhzha @ConnorMcMahon