Worker code path warmup #9018
Merged
Worker code path warmup #9018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyju
reviewed
Jan 4, 2023
src/WebJobs.Script.Grpc/azure-functions-language-worker-protobuf/src/proto/FunctionRpc.proto
Outdated
Show resolved
Hide resolved
liliankasem
reviewed
Jan 5, 2023
src/WebJobs.Script/Workers/Rpc/WebHostRpcWorkerChannelManager.cs
Outdated
Show resolved
Hide resolved
src/WebJobs.Script/Workers/Rpc/WebHostRpcWorkerChannelManager.cs
Outdated
Show resolved
Hide resolved
safihamid
reviewed
Jan 5, 2023
src/WebJobs.Script/Workers/Rpc/WebHostRpcWorkerChannelManager.cs
Outdated
Show resolved
Hide resolved
safihamid
reviewed
Jan 5, 2023
src/WebJobs.Script/Workers/Rpc/WebHostRpcWorkerChannelManager.cs
Outdated
Show resolved
Hide resolved
safihamid
reviewed
Jan 5, 2023
test/WebJobs.Script.Tests/Middleware/HostWarmupMiddlewareTests.cs
Outdated
Show resolved
Hide resolved
safihamid
reviewed
Jan 5, 2023
safihamid
reviewed
Jan 6, 2023
kshyju
reviewed
Jan 7, 2023
kshyju
reviewed
Jan 17, 2023
Member
There was a problem hiding this comment.
If worker is not supporting this capability, don't we need to set the result (to false)? Because ProcessWorkerWarmupResponse will not execute in that case. Correct? I know we await this method and I am wondering that will handle the tasks status "WaitingForActivation" (The default status) in this case.
src/WebJobs.Script/Workers/Rpc/WebHostRpcWorkerChannelManager.cs
Outdated
Show resolved
Hide resolved
shreyas-gopalakrishna
force-pushed
the
shreyasg/java-warmup
branch
from
a7aab5e to
795a240
Compare
ghost
removed
the
This was referenced Jan 30, 2023
shreyas-gopalakrishna
force-pushed
the
shreyasg/java-warmup
branch
from
795a240 to
418d333
Compare
shreyas-gopalakrishna
requested review from
kshyju,
liliankasem and
safihamid
safihamid
reviewed
Jan 31, 2023
safihamid
reviewed
Jan 31, 2023
src/WebJobs.Script/Workers/Rpc/WebHostRpcWorkerChannelManager.cs
Outdated
Show resolved
Hide resolved
liliankasem
reviewed
Jan 31, 2023
src/WebJobs.Script/Workers/Rpc/WebHostRpcWorkerChannelManager.cs
Outdated
Show resolved
Hide resolved
liliankasem
reviewed
Jan 31, 2023
liliankasem
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worker code path warmup
Use the HostWarmupMiddleware to send the WorkerWarmupRequest to warm up the worker code path before specialization.
PR for protobuf changes: Azure/azure-functions-language-worker-protobuf#84
Pull request checklist
release_notes.md