Skip to content

fix: allow source to be string and enum #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 9, 2024
Merged

fix: allow source to be string and enum #256

merged 4 commits into from
Oct 9, 2024

Conversation

@hallvictoria
Copy link
Contributor

@hallvictoria hallvictoria commented Oct 9, 2024 •
edited
Loading

With the changes from #249, only BlobSource values were accepted. If the user put a string, indexing would fail.

This changes the source parameter to accept both BlobSource and string values.

@hallvictoria hallvictoria marked this pull request as ready for review October 9, 2024 14:53
gavin-aguiar
gavin-aguiar reviewed Oct 9, 2024
View reviewed changes
@hallvictoria hallvictoria merged commit 5f656ad into dev Oct 9, 2024
10 checks passed
@hallvictoria hallvictoria deleted the hallvictoria/blobsource-fix branch October 9, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavin-aguiar gavin-aguiar gavin-aguiar approved these changes

@vrdmr vrdmr Awaiting requested review from vrdmr vrdmr is a code owner

@YunchuWang YunchuWang Awaiting requested review from YunchuWang

@pdthummar pdthummar Awaiting requested review from pdthummar

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hallvictoria @gavin-aguiar