Allow null value when blob doesnt exist #40
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hazhzeng @anirudhgarg Could you please take a look at this PR? Thanks! |
Hazhzeng
reviewed
Feb 12, 2020
Comment on lines
+78
to
+80
| if data is None or data.type is None: | ||
| return None | ||
|
|
There was a problem hiding this comment.
Hi @kolafsson, thanks for contributing to azure-functions-python-library
Please add a few unit tests regarding to this scenario.
Unit test examples: https://github.com/Azure/azure-functions-python-library/pull/28/files#diff-c27162ae93fd2aa43a783ef13d1749f4R9-R12
Thanks.
|
Moving to PR #67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns None when a customer tries to access blob that doesn't exist