Skip to content

Conversation

@pdthummar
Copy link
Contributor

Description

Adding legacy and Pystein timer trigger e2e tests

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #1131 (004cfb3) into dev (052b416) will decrease coverage by 52.27%.
The diff coverage is n/a.

❗ Current head 004cfb3 differs from pull request most recent head 44a8b29. Consider uploading reports for the commit 44a8b29 to get more accurate results

@@             Coverage Diff             @@
##              dev    #1131       +/-   ##
===========================================
- Coverage   83.71%   31.44%   -52.27%     
===========================================
  Files          34       34               
  Lines        1885     1873       -12     
  Branches      276      276               
===========================================
- Hits         1578      589      -989     
- Misses        236     1283     +1047     
+ Partials       71        1       -70     
Flag Coverage Δ
unittests 31.44% <ø> (-52.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e_functions_worker/bindings/nullable_converters.py 21.62% <0.00%> (-78.38%) ⬇️
azure_functions_worker/functions.py 25.00% <0.00%> (-71.28%) ⬇️
azure_functions_worker/dispatcher.py 19.01% <0.00%> (-69.85%) ⬇️
azure_functions_worker/utils/tracing.py 31.81% <0.00%> (-68.19%) ⬇️
azure_functions_worker/utils/common.py 33.33% <0.00%> (-66.67%) ⬇️
azure_functions_worker/bindings/meta.py 25.30% <0.00%> (-57.84%) ⬇️
...s/shared_memory_data_transfer/shared_memory_map.py 28.57% <0.00%> (-55.36%) ⬇️
azure_functions_worker/extension.py 43.92% <0.00%> (-55.16%) ⬇️
.../shared_memory_data_transfer/file_accessor_unix.py 19.60% <0.00%> (-54.91%) ⬇️
azure_functions_worker/utils/dependency.py 33.08% <0.00%> (-53.39%) ⬇️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghost ghost removed the needs-author feedback label Oct 25, 2022
@pdthummar pdthummar merged commit 1c577b0 into dev Jan 24, 2023
@pdthummar pdthummar deleted the pthummar/add_timer_tests branch January 24, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants