[Compute] New-AzRestorePoint and New-AzRestorePointCollection (#17665)

haagha · BethanyZhou · web-flow · commit 4ef627939e9f · 2022-03-30T13:32:28.000+08:00
* Powershell updates

* Powershell updates

* help file update

* updates to help and parametersets

* parameter sets

* Update src/Compute/Compute/ChangeLog.md

Co-authored-by: Beisi Zhou &lt;zhoubeisi@gmail.com&gt;

* Updates for PR changes requested.

* description update

* Update BreakingChangeIssues.csv

* update help

Co-authored-by: Beisi Zhou &lt;zhoubeisi@gmail.com&gt;
diff --git a/src/Compute/Compute/ChangeLog.md b/src/Compute/Compute/ChangeLog.md
@@ -25,6 +25,8 @@
 * Updated `Get-AzVm` to include `GetVirtualMachineById` parameter set.
 * Edited the documentation for the cmdlet `Set-AzVMADDomainExtension` to ensure the example is accurate. 
 * Improved description and examples for disk creation.
+* Added new parameters to `New-AzRestorePoint` and `New-AzRestorePointCollection` for copying Restore Points and Restore Point Collections.
+* Added `Zone` and `PlacementGroupId` Parameters to `Repair-AzVmssServiceFabricUpdateDomain`.
 
 ## Version 4.24.1
 * Updated New-AzVM feature for `vCPUsAvailable` and `vCPUsPerCore` parameters. Cmdlets will not try to use the new `VMCustomizationPreview` feature if the user does not have access to that feature. [#17370]
diff --git a/src/Compute/Compute/Generated/VirtualMachineScaleSet/VirtualMachineScaleSetForceRecoveryServiceFabricPlatformUpdateDomainWalkMethod.cs b/src/Compute/Compute/Generated/VirtualMachineScaleSet/VirtualMachineScaleSetForceRecoveryServiceFabricPlatformUpdateDomainWalkMethod.cs
@@ -46,6 +46,9 @@ public override void ExecuteCmdlet()
                 {
                     string resourceGroupName;
                     string vmScaleSetName;
+                    string zone = this.Zone;
+                    string placementgroupid = this.PlacementGroupId;
+
                     switch (this.ParameterSetName)
                     {
                         case "ResourceIdParameter":
@@ -62,8 +65,7 @@ public override void ExecuteCmdlet()
                             break;
                     }
                     int platformUpdateDomain = this.PlatformUpdateDomain;
-
-                    var result = VirtualMachineScaleSetsClient.ForceRecoveryServiceFabricPlatformUpdateDomainWalk(resourceGroupName, vmScaleSetName, platformUpdateDomain);
+                    var result = VirtualMachineScaleSetsClient.ForceRecoveryServiceFabricPlatformUpdateDomainWalk(resourceGroupName, vmScaleSetName, platformUpdateDomain, zone: zone, placementGroupId: placementgroupid);
                     var psObject = new PSRecoveryWalkResponse();
                     ComputeAutomationAutoMapperProfile.Mapper.Map<RecoveryWalkResponse, PSRecoveryWalkResponse>(result, psObject);
                     WriteObject(psObject);
@@ -93,6 +95,16 @@ public override void ExecuteCmdlet()
             Mandatory = true)]
         public int PlatformUpdateDomain { get; set; }
 
+        [Parameter(
+            Mandatory = false,
+            HelpMessage = "Set the Zone for the VMSS")]
+        public string Zone { get; set; }
+
+        [Parameter(
+            Mandatory = false,
+            HelpMessage = "Set the Placement Group Id")]
+        public string PlacementGroupId { get; set; }
+
         [Parameter(
             ParameterSetName = "ResourceIdParameter",
             Position = 0,
diff --git a/src/Compute/Compute/RestorePoints/NewAzRestorePoint.cs b/src/Compute/Compute/RestorePoints/NewAzRestorePoint.cs
@@ -53,6 +53,20 @@ public class NewAzureRestorePoint : ComputeAutomationBaseCmdlet
 
         [Parameter(
             Position = 3,
+            Mandatory = false,
+            ValueFromPipelineByPropertyName = false,
+            HelpMessage = "Set the region of the Restore Point")]
+        public string Location { get; set; }
+
+
+        [Parameter(
+            Mandatory = false,
+            ValueFromPipeline = true,
+            HelpMessage = "ARM Id of the source Restore Point")]
+        public string RestorePointId { get; set; }
+
+
+        [Parameter(
             Mandatory = false,
             ValueFromPipeline = true)]
         public string[] DisksToExclude { get; set; }
@@ -68,29 +82,31 @@ public override void ExecuteCmdlet()
                     string resourceGroup = this.ResourceGroupName;
                     string restorePointName = this.Name;
                     string restorePointCollectionName = this.RestorePointCollectionName;
+                    string location = this.Location;
+                    string restorePointId = this.RestorePointId;
                     List<ApiEntityReference> disksExclude = new List<ApiEntityReference>();
 
                     RestorePoint restorePoint = new RestorePoint();
+
+                    if(this.IsParameterBound(c=> c.RestorePointId))
+                    {
+                        restorePoint.SourceRestorePoint = new ApiEntityReference { Id = restorePointId };
+                    }
+
                     if (this.IsParameterBound(c => c.DisksToExclude))
                     {
                         foreach (string s in DisksToExclude)
                         {
                             disksExclude.Add(new ApiEntityReference(s));
                         }
                         restorePoint.ExcludeDisks = disksExclude;
-                        var result = RestorePointClient.Create(resourceGroup, restorePointCollectionName, restorePointName, restorePoint);
-                        var psObject = new PSRestorePoint();
-                        ComputeAutomationAutoMapperProfile.Mapper.Map<RestorePoint, PSRestorePoint>(result, psObject);
-                        WriteObject(psObject);
-
-                    }
-                    else
-                    {
-                        var result = RestorePointClient.Create(resourceGroup, restorePointCollectionName, restorePointName, restorePoint);
-                        var psObject = new PSRestorePoint();
-                        ComputeAutomationAutoMapperProfile.Mapper.Map<RestorePoint, PSRestorePoint>(result, psObject);
-                        WriteObject(psObject);
                     }
+
+                    var result = RestorePointClient.Create(resourceGroup, restorePointCollectionName, restorePointName, restorePoint);
+                        
+                    var psObject = new PSRestorePoint();
+                    ComputeAutomationAutoMapperProfile.Mapper.Map<RestorePoint, PSRestorePoint>(result, psObject);
+                    WriteObject(psObject);
                 }
             });
         }
diff --git a/src/Compute/Compute/RestorePoints/NewAzRestorePointCollection.cs b/src/Compute/Compute/RestorePoints/NewAzRestorePointCollection.cs
@@ -32,6 +32,12 @@ public class NewAzureRestorePointCollection : ComputeAutomationBaseCmdlet
     {
 
         [Parameter(
+            ParameterSetName = "DefaultParameter",
+            Position = 0,
+            Mandatory = true,
+            ValueFromPipelineByPropertyName = true)]
+        [Parameter(
+            ParameterSetName = "RestorePointCollectionId",
             Position = 0,
             Mandatory = true,
             ValueFromPipelineByPropertyName = true)]
@@ -40,6 +46,12 @@ public class NewAzureRestorePointCollection : ComputeAutomationBaseCmdlet
 
         [Parameter(
             Position = 1,
+            ParameterSetName = "DefaultParameter",
+            Mandatory = true,
+            ValueFromPipelineByPropertyName = true)]
+        [Parameter(
+            Position = 1,
+            ParameterSetName = "RestorePointCollectionId",
             Mandatory = true,
             ValueFromPipelineByPropertyName = true)]
         [Alias("RestorePointCollectionName")]
@@ -48,35 +60,81 @@ public class NewAzureRestorePointCollection : ComputeAutomationBaseCmdlet
         [Parameter(
             Position = 2,
             Mandatory = true,
-            ValueFromPipeline = true)]
+            ValueFromPipeline = true,
+            ParameterSetName = "DefaultParameter")]
+        [Parameter(
+            Position = 2,
+            Mandatory = false,
+            ValueFromPipeline = true,
+            ParameterSetName = "RestorePointCollectionId")]
         public string VmId { get; set; }
 
         [Parameter(
             Position = 3,
             Mandatory = true,
+            ValueFromPipeline = true,
+            ParameterSetName = "RestorePointCollectionId",
+            HelpMessage = "ARM Id for the source Restore Point Collection")]
+        public string RestorePointCollectionId { get; set; }
+
+        [Parameter(
+            ParameterSetName = "DefaultParameter",
+            Mandatory = false,
             ValueFromPipeline = true)]
+        [Parameter(
+            ParameterSetName = "RestorePointCollectionId",
+            Mandatory = true,
+            ValueFromPipeline = true,
+            HelpMessage = "Location of the source Restore Point Collection")]
         public string Location { get; set; }
 
-
         public override void ExecuteCmdlet()
         {
             base.ExecuteCmdlet();
             ExecuteClientAction(() =>
             {
                 if (ShouldProcess(this.Name, VerbsCommon.New))
                 {
-                    string resourceGroup = this.ResourceGroupName;
-                    string restorePointCollectionName = this.Name;
-                    string vmId = this.VmId;
-                    string location = this.Location;
+                    if (ParameterSetName == "DefaultParameter")
+                    {
+                        string resourceGroup = this.ResourceGroupName;
+                        string restorePointCollectionName = this.Name;
+                        string vmId = this.VmId;
+                        RestorePointCollection restorePointCollection;
+                        if (this.IsParameterBound(c => c.Location))
+                        {
+                            string location = this.Location;
+                            restorePointCollection = new RestorePointCollection(location);
+                            restorePointCollection.Source = new RestorePointCollectionSourceProperties() { Id = vmId };
+
+                        }
+                        else
+                        {
+                            restorePointCollection = new RestorePointCollection();
+                            restorePointCollection.Source = new RestorePointCollectionSourceProperties() { Id = vmId };
+
+                        }
+
+                        var result = RestorePointCollectionsClient.CreateOrUpdate(resourceGroup, restorePointCollectionName, restorePointCollection);
+                        var psObject = new PSRestorePointCollection();
+                        ComputeAutomationAutoMapperProfile.Mapper.Map<RestorePointCollection, PSRestorePointCollection>(result, psObject);
+                        WriteObject(psObject);
+                    }
+                    else if(ParameterSetName == "RestorePointCollectionId")
+                    {
+                        string resourceGroup = this.ResourceGroupName;
+                        string restorePointCollectionName = this.Name;
+                        string restorePointCollectionId = this.RestorePointCollectionId;
+                        string location = this.Location;
 
-                    RestorePointCollection restorePointCollection = new RestorePointCollection(location);
-                    restorePointCollection.Source = new RestorePointCollectionSourceProperties() { Id = vmId }; 
+                        RestorePointCollection restorePointCollection = new RestorePointCollection(location, restorePointCollectionId: restorePointCollectionId);
+                        restorePointCollection.Source = new RestorePointCollectionSourceProperties(location, RestorePointCollectionId);
 
-                    var result = RestorePointCollectionsClient.CreateOrUpdate(resourceGroup, restorePointCollectionName, restorePointCollection);
-                    var psObject = new PSRestorePointCollection();
-                    ComputeAutomationAutoMapperProfile.Mapper.Map<RestorePointCollection, PSRestorePointCollection>(result, psObject);
-                    WriteObject(psObject);
+                        var result = RestorePointCollectionsClient.CreateOrUpdate(resourceGroup, restorePointCollectionName, restorePointCollection);
+                        var psObject = new PSRestorePointCollection();
+                        ComputeAutomationAutoMapperProfile.Mapper.Map<RestorePointCollection, PSRestorePointCollection>(result, psObject);
+                        WriteObject(psObject);
+                    }
                 }
             });
         }
diff --git a/src/Compute/Compute/help/Az.Compute.md b/src/Compute/Compute/help/Az.Compute.md
@@ -615,7 +615,7 @@ Configures the DSC extension on a virtual machine.
 Updates extension properties or adds an extension to a virtual machine.
 
 ### [Set-AzVMOperatingSystem](Set-AzVMOperatingSystem.md)
-Sets operating system properties for a virtual machine.
+Sets operating system properties during the creation of a new virtual machine.
 
 ### [Set-AzVMOSDisk](Set-AzVMOSDisk.md)
 Sets the operating system disk properties on a virtual machine.
diff --git a/src/Compute/Compute/help/New-AzRestorePoint.md b/src/Compute/Compute/help/New-AzRestorePoint.md
@@ -14,8 +14,8 @@ This cmdlet can create a New Restore Point
 
 ```
 New-AzRestorePoint [-ResourceGroupName] <String> [-RestorePointCollectionName] <String> [-Name] <String>
- [[-DisksToExclude] <String[]>] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm]
- [<CommonParameters>]
+ [[-Location] <String>] [-RestorePointId <String>] [-DisksToExclude <String[]>]
+ [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm] [<CommonParameters>]
 ```
 
 ## DESCRIPTION
@@ -36,7 +36,7 @@ Creates a new Restore Point
 The credentials, account, tenant, and subscription used for communication with Azure.
 
 ```yaml
-Type: IAzureContextContainer
+Type: Microsoft.Azure.Commands.Common.Authentication.Abstractions.Core.IAzureContextContainer
 Parameter Sets: (All)
 Aliases: AzContext, AzureRmContext, AzureCredential
 
@@ -51,22 +51,37 @@ Accept wildcard characters: False
 List of disk resource ids that the customer wishes to exclude from the restorepoint. If no disks are specified, all disks will be included.
 
 ```yaml
-Type: String[]
+Type: System.String[]
 Parameter Sets: (All)
 Aliases:
 
 Required: False
-Position: 3
+Position: Named
 Default value: None
 Accept pipeline input: True (ByValue)
 Accept wildcard characters: False
 ```
 
+### -Location
+{{ Fill Location Description }}
+
+```yaml
+Type: System.String
+Parameter Sets: (All)
+Aliases:
+
+Required: False
+Position: 3
+Default value: None
+Accept pipeline input: False
+Accept wildcard characters: False
+```
+
 ### -Name
 Resource Name
 
 ```yaml
-Type: String
+Type: System.String
 Parameter Sets: (All)
 Aliases: RestorePointName
 
@@ -81,7 +96,7 @@ Accept wildcard characters: False
 Resource Group Name
 
 ```yaml
-Type: String
+Type: System.String
 Parameter Sets: (All)
 Aliases:
 
@@ -96,7 +111,7 @@ Accept wildcard characters: False
 Restore Point Collection Name
 
 ```yaml
-Type: String
+Type: System.String
 Parameter Sets: (All)
 Aliases:
 
@@ -107,11 +122,26 @@ Accept pipeline input: True (ByPropertyName)
 Accept wildcard characters: False
 ```
 
+### -RestorePointId
+{{ Fill RestorePointId Description }}
+
+```yaml
+Type: System.String
+Parameter Sets: (All)
+Aliases:
+
+Required: False
+Position: Named
+Default value: None
+Accept pipeline input: True (ByValue)
+Accept wildcard characters: False
+```
+
 ### -Confirm
 Prompts you for confirmation before running the cmdlet.
 
 ```yaml
-Type: SwitchParameter
+Type: System.Management.Automation.SwitchParameter
 Parameter Sets: (All)
 Aliases: cf
 
@@ -127,7 +157,7 @@ Shows what would happen if the cmdlet runs.
 The cmdlet is not run.
 
 ```yaml
-Type: SwitchParameter
+Type: System.Management.Automation.SwitchParameter
 Parameter Sets: (All)
 Aliases: wi
 
diff --git a/src/Compute/Compute/help/New-AzRestorePointCollection.md b/src/Compute/Compute/help/New-AzRestorePointCollection.md
diff --git a/src/Compute/Compute/help/Repair-AzVmssServiceFabricUpdateDomain.md b/src/Compute/Compute/help/Repair-AzVmssServiceFabricUpdateDomain.md
diff --git a/tools/StaticAnalysis/Exceptions/Az.Compute/BreakingChangeIssues.csv b/tools/StaticAnalysis/Exceptions/Az.Compute/BreakingChangeIssues.csv
