[Compute] New-AzRestorePoint and New-AzRestorePointCollection #17665

haagha · 2022-03-29T05:16:25Z

(https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1098)

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate ChangeLog.md file(s) has been updated:
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
  - {Please put the link here}
- the markdown help files have been regenerated using the commands listed here

haagha · 2022-03-29T06:35:29Z

@BethanyZhou can you please add this to the March release? Thanks.

BethanyZhou · 2022-03-29T08:52:53Z

src/Compute/Compute/RestorePoints/NewAzRestorePoint.cs

        public string Name { get; set; }

        [Parameter(
-            Position = 3,


Removing position may break user's script, please revert these changes.

src/Compute/Compute/ChangeLog.md

BethanyZhou · 2022-03-29T09:01:07Z

Please fix analyze issues and test issues.

[xUnit.net 00:01:50.05] Microsoft.Azure.Commands.Compute.Test.ScenarioTests.RestorePointsTests.TestRestorePoints [FAIL]

/Users/runner/work/1/s/artifacts//StaticAnalysisResults/BreakingChangeIssues.csv Errors
"AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation"
"Az.Compute","Microsoft.Azure.Commands.Compute.Automation.NewAzureRestorePoint","New-AzRestorePoint","0","1050","The parameter set '__AllParameterSets' for cmdlet 'New-AzRestorePoint' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'New-AzRestorePoint'."
"Az.Compute","Microsoft.Azure.Commands.Compute.Automation.NewAzureRestorePointCollection","New-AzRestorePointCollection","0","1050","The parameter set '__AllParameterSets' for cmdlet 'New-AzRestorePointCollection' has been removed.","Add parameter set '__AllParameterSets' back to cmdlet 'New-AzRestorePointCollection'."

BethanyZhou · 2022-03-29T09:06:10Z

@BethanyZhou can you please add this to the March release? Thanks.

Our code freeze date is 03/28 and we are building release candidate for March release.

Any special reason to must have this PR in March release? If so, please fix comments above ASAP and let us see this PR whether has change to squeeze into release candidate.

haagha · 2022-03-29T14:54:11Z

@BethanyZhou yes this is request customers are waiting on, I will fix the PR and let you know.

Co-authored-by: Beisi Zhou <[email protected]>

haagha · 2022-03-29T21:11:09Z

@BethanyZhou The Static analysis failure seems like a false positive.
It says in this document https://github.com/Azure/azure-powershell/blob/main/documentation/Debugging-StaticAnalysis-Errors.md
"Note: Sometimes the error listed in the .csv file can be a false positive (for example, if you change a parameter attribute to span all parameter sets rather than individual parameter sets)."

BethanyZhou · 2022-03-30T01:24:18Z

Yes, please suppress them in suppress the breaking change errors in tools/StaticAnalysis/Exceptions/${ModuleName}/BreakingChangeIssues.csv"

BethanyZhou · 2022-03-30T01:39:18Z

src/Compute/Compute/help/New-AzRestorePoint.md

- [[-DisksToExclude] <String[]>] [-DefaultProfile <IAzureContextContainer>] [-WhatIf] [-Confirm]
- [<CommonParameters>]
+New-AzRestorePoint [-ResourceGroupName] <String> -RestorePointCollectionName <String> -Name <String>
+ [-Location <String>] -RestorePointId <String> [-DisksToExclude <String[]>]


please update markdown files to keep sync with code implementation. The syntax says RestorePointCollectionName is not a positional parameter now. Need be updated.

BethanyZhou · 2022-03-30T01:39:49Z

src/Compute/Compute/help/New-AzRestorePoint.md

 ```

+### -Location
+{{ Fill Location Description }}


The description of Location is missing, please add help message for it.

BethanyZhou · 2022-03-30T01:40:57Z

src/Compute/Compute/RestorePoints/NewAzRestorePoint.cs

            Position = 3,
+            Mandatory = false,
+            ValueFromPipelineByPropertyName = false)]
+        public string Location { get; set; }


please add help message for new added parameters.

BethanyZhou · 2022-03-30T01:41:24Z

src/Compute/Compute/help/New-AzRestorePoint.md

 ```

+### -RestorePointId
+{{ Fill RestorePointId Description }}


This one needs help message as well.

BethanyZhou · 2022-03-30T01:41:41Z

src/Compute/Compute/help/New-AzRestorePointCollection.md

 Aliases:

 Required: True
-Position: 2


Please update markdown files.

BethanyZhou · 2022-03-30T01:42:12Z

src/Compute/Compute/help/Repair-AzVmssServiceFabricUpdateDomain.md

 ```

+### -Zone
+{{ Fill Zone Description }}


Needs description. To add it, please add help message in cs file.

dingmeng-xue · 2022-03-30T02:50:18Z

src/Compute/Compute/help/New-AzRestorePointCollection.md

 ```

+### -RestorePointCollectionId
+{{ Fill RestorePointCollectionId Description }}


Description is empty.

…/azure-powershell into haagha/restorepointchanges

haagha · 2022-03-30T02:53:40Z

Added static analysis to breaking changes supression csv and updated descriptions and help files.

BethanyZhou · 2022-03-30T03:03:27Z

Seems like you forget to update Repair-AzVmssServiceFabricUpdateDomain.md the description of Zone and PlacementGroupId is empty, please have a look.

BethanyZhou

All look good to me except Repair-AzVmssServiceFabricUpdateDomain.md

…/azure-powershell into haagha/restorepointchanges

BethanyZhou

Looks good to me

Powershell updates

519c4fb

haagha requested review from Sandido, bilaakpan-ms and grizzlytheodore as code owners March 29, 2022 05:16

haagha added 4 commits March 29, 2022 01:36

Powershell updates

0c7d5ef

help file update

0df6fed

updates to help and parametersets

5e5aad1

merge

7043d2b

haagha assigned BethanyZhou Mar 29, 2022

BethanyZhou reviewed Mar 29, 2022

View reviewed changes

haagha and others added 2 commits March 29, 2022 15:46

parameter sets

87f59c7

Update src/Compute/Compute/ChangeLog.md

2d8f033

Co-authored-by: Beisi Zhou <[email protected]>

BethanyZhou changed the base branch from main to release-2022-04-05 March 30, 2022 01:37

BethanyZhou added this to the Mar 2022 (2022-04-05) milestone Mar 30, 2022

BethanyZhou suggested changes Mar 30, 2022

View reviewed changes

BethanyZhou and others added 2 commits March 30, 2022 09:42

Merge branch 'release-2022-04-05' into haagha/restorepointchanges

51769fe

Updates for PR changes requested.

4479487

dingmeng-xue reviewed Mar 30, 2022

View reviewed changes

haagha added 2 commits March 29, 2022 22:50

Merge branch 'haagha/restorepointchanges' of https://github.com/Azure…

3699b9a

…/azure-powershell into haagha/restorepointchanges

description update

4144bcb

haagha requested a review from BethanyZhou March 30, 2022 02:54

BethanyZhou reviewed Mar 30, 2022

View reviewed changes

BethanyZhou and others added 3 commits March 30, 2022 11:55

Update BreakingChangeIssues.csv

837bd3f

update help

02e3541

Merge branch 'haagha/restorepointchanges' of https://github.com/Azure…

32d0949

…/azure-powershell into haagha/restorepointchanges

haagha requested a review from BethanyZhou March 30, 2022 04:05

BethanyZhou approved these changes Mar 30, 2022

View reviewed changes

BethanyZhou merged commit 4ef6279 into release-2022-04-05 Mar 30, 2022

[Compute] New-AzRestorePoint and New-AzRestorePointCollection #17665

[Compute] New-AzRestorePoint and New-AzRestorePointCollection #17665

Uh oh!

Conversation

haagha commented Mar 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

haagha commented Mar 29, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BethanyZhou commented Mar 29, 2022

Uh oh!

BethanyZhou commented Mar 29, 2022

Uh oh!

haagha commented Mar 29, 2022

Uh oh!

haagha commented Mar 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BethanyZhou commented Mar 30, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

haagha commented Mar 30, 2022

Uh oh!

BethanyZhou commented Mar 30, 2022

Uh oh!

BethanyZhou left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BethanyZhou left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

haagha commented Mar 29, 2022 •

edited

Loading

haagha commented Mar 29, 2022 •

edited

Loading

BethanyZhou left a comment •

edited

Loading