Skip to content

Conversation

@Xynoclafe
Copy link
Contributor

@Xynoclafe Xynoclafe commented Oct 27, 2020

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@Xynoclafe Xynoclafe requested a review from filizt October 27, 2020 17:11
@Xynoclafe Xynoclafe changed the title Follow-up fixes for #13275 Follow-up fixes for https://github.com/Azure/azure-powershell/pull/13275 Oct 27, 2020
var resourceGroupId = this.GetResourceGroupId();

if (this.IsParameterBound(c => c.ApiVersion))
if (! this.IsParameterBound(c => c.ApiVersion))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit - extra space

Copy link
Contributor

@filizt filizt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just a nit comment)

@isra-fel isra-fel merged commit dd2beae into Azure:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants