Virtual Wan P2S MultiPool feature changes #17032

Nilambari · 2022-02-07T23:09:14Z

Description

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate ChangeLog.md file(s) has been updated:
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
  https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1127
- the markdown help files have been regenerated using the commands listed here

BethanyZhou · 2022-03-01T05:40:26Z

CI failed: The type or namespace name 'IConfigurationPolicyGroupsOperations' could not be found (are you missing a using directive or an assembly reference?) Please have a look.

BethanyZhou · 2022-03-01T05:29:25Z

src/Network/Network.Test/ScenarioTests/CortexTests.ps1

 		Assert-AreEqual "Succeeded" $P2SVpnGateway.ProvisioningState
 		Assert-AreEqual 1 @($P2SVpnGateway.CustomDnsServers).Count
-        	Assert-AreEqual "7.7.7.7" $P2SVpnGateway.CustomDnsServers[0]
+        Assert-AreEqual "7.7.7.7" $P2SVpnGateway.CustomDnsServers[0]


Suggested change

Assert-AreEqual "7.7.7.7" $P2SVpnGateway.CustomDnsServers[0]

Assert-AreEqual "7.7.7.7" $P2SVpnGateway.CustomDnsServers[0]

BethanyZhou · 2022-03-01T05:29:58Z

src/Network/Network.Test/ScenarioTests/CortexTests.ps1

+        $job = Reset-AzP2sVpnGateway -P2SVpnGateway $P2SVpnGateway -AsJob
+	    $job | Wait-Job
+	    $actual = $job | Receive-Job


Please correct indents.

src/Network/Network/Az.Network.psd1

Nilambari · 2022-04-14T07:58:54Z

@isra-fel Incorporate review comment. Please take a look.

Nilambari · 2022-04-14T07:59:43Z

CI failed: The type or namespace name 'IConfigurationPolicyGroupsOperations' could not be found (are you missing a using directive or an assembly reference?) Please have a look.

Waiting for latest network SDK generation.

isra-fel · 2022-04-17T17:01:41Z

Generally looks good. Please regenerate help documents and resolve the conflicts.

Nilambari · 2022-04-26T07:23:10Z

Generally looks good. Please regenerate help documents and resolve the conflicts.

Done. @isra-fel Please take a look. Thanks!

isra-fel

This file src/Network/Network/help/Az.Network.md is supposed to be updated when introducing new cmdlets.
Please make sure to use -RefreshModulePage when regenerating helps, see https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/help-generation.md#updating-all-markdown-files-in-a-module

nilambarideshpande · 2022-04-27T04:56:28Z

This file src/Network/Network/help/Az.Network.md is supposed to be updated when introducing new cmdlets.
Please make sure to use -RefreshModulePage when regenerating helps, see https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/help-generation.md#updating-all-markdown-files-in-a-module

Let me update it. Thanks.

Nilambari · 2022-04-27T06:56:04Z

Let me update it. Thanks.

Incorporated review comments & included latest test recording as well. @isra-fel Please take a look and help approve this PR. Thanks!

… nilamd_network-2021-08-01

isra-fel · 2022-04-27T09:59:39Z

/azp run azure-powershell - security-tools

azure-pipelines · 2022-04-27T09:59:46Z

Azure Pipelines successfully started running 1 pipeline(s).

Nilambari added 2 commits February 7, 2022 14:03

MultiPool feature changes Part1

fed556b

bug fix

d519ee8

Nilambari requested a review from MikhailTryakhov as a code owner February 7, 2022 23:09

Nilambari changed the title ~~Virtual Wan P2S MultiPool feature changes~~ Draft: Virtual Wan P2S MultiPool feature changes Feb 7, 2022

VeryEarly marked this pull request as draft February 8, 2022 07:58

Nilambari added 5 commits February 8, 2022 19:24

Command let changes

3ef2246

Add change log

fb2cdbe

Fix command let

e182118

Test update

1e9492a

Incorporate review comments

66f4041

Nilambari changed the title ~~Draft: Virtual Wan P2S MultiPool feature changes~~ Virtual Wan P2S MultiPool feature changes Feb 22, 2022

Nilambari marked this pull request as ready for review February 22, 2022 23:54

Fixes

7311ea6

BethanyZhou reviewed Mar 1, 2022

View reviewed changes

BethanyZhou self-assigned this Mar 1, 2022

Incorporate review comments

860f091

isra-fel assigned isra-fel and unassigned BethanyZhou Apr 2, 2022

isra-fel added the needs-review label Apr 2, 2022

isra-fel and others added 3 commits April 11, 2022 16:37

Merge branch 'network-2021-08-01' into nilamd_network-2021-08-01

2b96deb

Merge branch 'network-2021-08-01' into nilamd_network-2021-08-01

0dc3b44

Incorpotate review comments

e94b7cb

isra-fel added the Cmdlet Review Complete label Apr 15, 2022

Nilambari added 2 commits April 15, 2022 12:17

Add missing field in cmd output

1f92306

Fix merge conflicts

9591fb8

isra-fel removed the needs-review label Apr 17, 2022

isra-fel added the needs-revision label Apr 17, 2022

isra-fel assigned Nilambari Apr 17, 2022

Nilambari added 2 commits April 25, 2022 23:03

Update help files

c53d8cd

Fix merge conflicts

90e7709

Nilambari added needs-review and removed needs-revision labels Apr 26, 2022

Minor fix

321f5af

isra-fel requested changes Apr 27, 2022

View reviewed changes

Update help file & include new test recording with new changes covered.

d1a1a67

Merge branch 'main' of https://github.com/Azure/azure-powershell into…

f01df70

… nilamd_network-2021-08-01

Nilambari changed the base branch from network-2021-08-01 to main April 27, 2022 07:49

Update ChangeLog.md

0b7c7d5

isra-fel added Waiting for CI and removed needs-review labels Apr 27, 2022

isra-fel unassigned Nilambari Apr 27, 2022

isra-fel approved these changes Apr 27, 2022

View reviewed changes

isra-fel merged commit 64a914b into Azure:main Apr 27, 2022

isra-fel mentioned this pull request May 26, 2022

Fix exception import Az.Accounts caused by environment variables #18311

Closed

8 tasks

	Assert-AreEqual "7.7.7.7" $P2SVpnGateway.CustomDnsServers[0]
	Assert-AreEqual "7.7.7.7" $P2SVpnGateway.CustomDnsServers[0]

Virtual Wan P2S MultiPool feature changes #17032

Virtual Wan P2S MultiPool feature changes #17032

Uh oh!

Conversation

Nilambari commented Feb 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

BethanyZhou commented Mar 1, 2022

Uh oh!

BethanyZhou Mar 1, 2022

Choose a reason for hiding this comment

Uh oh!

BethanyZhou Mar 1, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Nilambari commented Apr 14, 2022

Uh oh!

Nilambari commented Apr 14, 2022

Uh oh!

isra-fel commented Apr 17, 2022

Uh oh!

Nilambari commented Apr 26, 2022

Uh oh!

isra-fel left a comment

Choose a reason for hiding this comment

Uh oh!

nilambarideshpande commented Apr 27, 2022

Uh oh!

Nilambari commented Apr 27, 2022

Uh oh!

isra-fel commented Apr 27, 2022

Uh oh!

azure-pipelines bot commented Apr 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Nilambari commented Feb 7, 2022 •

edited

Loading