Skip to content

Fix Az.Resources Syntax Errors #17769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 25, 2022
Merged

Fix Az.Resources Syntax Errors #17769

merged 5 commits into from
Apr 25, 2022

Conversation

@CaptainFanZzz
Copy link
Contributor

@CaptainFanZzz CaptainFanZzz commented Apr 11, 2022 •
edited
Loading

Description

Fix Az.Resources Syntax Errors
generation branch #17770

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@CaptainFanZzz CaptainFanZzz mentioned this pull request Apr 11, 2022
Merged
8 tasks
ziyuezh576
ziyuezh576 previously approved these changes Apr 18, 2022
View reviewed changes
isra-fel
isra-fel requested changes Apr 21, 2022
View reviewed changes
src/Resources/Resources/help/Get-AzTag.md Outdated

```powershell
Get-AzTag -ResourceId /subscriptions/{subId}
Get-AzTag -ResourceId /subscriptions/xxxx-xxxx-xxxx-xxxx-xxxx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Get-AzTag -ResourceId /subscriptions/xxxx-xxxx-xxxx-xxxx-xxxx
Get-AzTag -ResourceId /subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx

GUID has a pattern

@CaptainFanZzz CaptainFanZzz requested a review from isra-fel April 22, 2022 11:16
isra-fel
isra-fel reviewed Apr 25, 2022
View reviewed changes
@isra-fel isra-fel assigned isra-fel and unassigned ziyuezh576 Apr 25, 2022
@isra-fel isra-fel merged commit 374a4a2 into Azure:main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isra-fel isra-fel isra-fel approved these changes

+1 more reviewer

@ziyuezh576 ziyuezh576 ziyuezh576 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@isra-fel isra-fel

Labels

Doc - Reference Waiting for CI :shipit:

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CaptainFanZzz @isra-fel @ziyuezh576