Skip to content

Add AnalysisServicesTestRunner and replace AsTestsBase #18056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 17, 2022
Merged

Add AnalysisServicesTestRunner and replace AsTestsBase #18056

merged 3 commits into from
May 17, 2022

Conversation

@CaptainFanZzz
Copy link
Contributor

@CaptainFanZzz CaptainFanZzz commented May 6, 2022

Description

Add AnalysisServicesTestRunner and replace AzTestsBase

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@CaptainFanZzz CaptainFanZzz added the Test Infra Test framework label May 6, 2022
@CaptainFanZzz CaptainFanZzz requested a review from ziyuezh576 May 6, 2022 05:08
ziyuezh576
ziyuezh576 suggested changes May 6, 2022
View reviewed changes
src/AnalysisServices/AnalysisServices.Test/ScenarioTests/AnalysisServicesTestRunner.cs Outdated
Copy link
Contributor

@ziyuezh576 ziyuezh576 May 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as the line above, delete it.

src/AnalysisServices/AnalysisServices.sln Outdated
Copy link
Contributor

@ziyuezh576 ziyuezh576 May 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't edit solution file

src/AnalysisServices/AnalysisServices.Test/ScenarioTests/AsTests.cs Outdated
Copy link
Contributor

@ziyuezh576 ziyuezh576 May 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete the empty line

@CaptainFanZzz CaptainFanZzz requested a review from ziyuezh576 May 6, 2022 11:53
@CaptainFanZzz CaptainFanZzz changed the title Add AnalysisServicesTestRunner and replace AzTestsBase Add AnalysisServicesTestRunner and replace AsTestsBase May 10, 2022
@CaptainFanZzz CaptainFanZzz force-pushed the AnalysisServicesTestRunner branch from f8ddeaa to d6f463c Compare May 10, 2022 04:32
@CaptainFanZzz CaptainFanZzz reopened this May 10, 2022
ziyuezh576
ziyuezh576 previously approved these changes May 10, 2022
View reviewed changes
vidai-msft
vidai-msft requested changes May 13, 2022
View reviewed changes
src/AnalysisServices/AnalysisServices.Test/InMemoryTests/DataPlaneCommandTests.cs Outdated
namespace Microsoft.Azure.Commands.AnalysisServices.Test.InMemoryTests
{
public class DataPlaneCommandTests : AsTestsBase
public class DataPlaneCommandTests : AnalysisServicesTestRunner
Copy link
Contributor

@vidai-msft vidai-msft May 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it inherit from RMTestBase instead of TestRunner

@CaptainFanZzz CaptainFanZzz requested a review from vidai-msft May 13, 2022 09:32
@vidai-msft vidai-msft merged commit a88dbd3 into Azure:main May 17, 2022
@isra-fel isra-fel mentioned this pull request May 26, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vidai-msft vidai-msft vidai-msft approved these changes

+1 more reviewer

@ziyuezh576 ziyuezh576 ziyuezh576 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Test Infra Test framework

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CaptainFanZzz @vidai-msft @ziyuezh576