Add CognitiveServicesTestRunner and replace TestController #18077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidai-msft
requested changes
May 9, 2022
Contributor
vidai-msft
left a comment
vidai-msft
left a comment
There was a problem hiding this comment.
Try to remove WithManagementClients method and make sure it has not impact on all the test casess
| {"Microsoft.Authorization", null}, | ||
| {"Microsoft.Network", null} | ||
| } | ||
| ).WithManagementClients( |
Contributor
There was a problem hiding this comment.
WithManagementClients method can be removed. Please make sure all tests can pass after removing it
| return context.GetServiceClient<ResourceManagementClient>(RestTestFramework.TestEnvironmentFactory.GetTestEnvironment()); | ||
| } | ||
|
|
||
| private static CognitiveServicesManagementClient GetCognitiveServicesManagementClient(RestTestFramework.MockContext context) |
Contributor
There was a problem hiding this comment.
GetCognitiveServiceManagementClient is not necessary. Please remove it.
| return context.GetServiceClient<CognitiveServicesManagementClient>(RestTestFramework.TestEnvironmentFactory.GetTestEnvironment()); | ||
| } | ||
|
|
||
| protected NetworkManagementClient GetNetworkClient(RestTestFramework.MockContext context) |
Contributor
There was a problem hiding this comment.
GetNetworkManagementClient is not necessary. Please remove it.
vidai-msft
approved these changes
May 10, 2022
vidai-msft
approved these changes
May 10, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added