Skip to content

added support for windows 2022 server for service fabric cluster #20825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2023
Merged

added support for windows 2022 server for service fabric cluster #20825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7660dff
added support for windows 2022 server
demodh Feb 2, 2023
f5277fe
updated changelog file based on comments
demodh Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/ServiceFabric/ServiceFabric/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
- Additional information about change #1
-->
## Upcoming Release
* Added support for Windows 2022 server vm image.
- This enables cluster operations with Windows 2022 server vm image

## Version 3.1.0
* Fixed typo in verbose log message.
Expand Down
4 changes: 3 additions & 1 deletion src/ServiceFabric/ServiceFabric/Commands/NewAzureRmServiceFabricCluster.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,8 @@ public class NewAzureRmServiceFabricCluster : ServiceFabricClusterCertificateCmd
{OperatingSystem.UbuntuServer1804, "18.04-LTS"},
{OperatingSystem.UbuntuServer2004, "20_04-LTS"},
{OperatingSystem.WindowsServer2016DatacenterwithContainers, "2016-Datacenter-with-Containers"},
{OperatingSystem.WindowsServer2016Datacenter, "2016-Datacenter"}
{OperatingSystem.WindowsServer2016Datacenter, "2016-Datacenter"},
{OperatingSystem.WindowsServer2022, "2022-datacenter-azure-edition"}
};

private string resourceLocation;
Expand Down Expand Up @@ -442,6 +443,7 @@ private void DeployWithDefaultTemplate()
case OperatingSystem.WindowsServer2012R2Datacenter:
case OperatingSystem.WindowsServer2016Datacenter:
case OperatingSystem.WindowsServer2016DatacenterwithContainers:
case OperatingSystem.WindowsServer2022:
osRelativePath = Constants.WindowsTemplateRelativePath;
break;
case OperatingSystem.UbuntuServer1604:
Expand Down
3 changes: 2 additions & 1 deletion src/ServiceFabric/ServiceFabric/Models/OperatingSystem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ public enum OperatingSystem
WindowsServer2016DatacenterwithContainers,
UbuntuServer1604,
UbuntuServer1804,
UbuntuServer2004
UbuntuServer2004,
WindowsServer2022
}
}
2 changes: 1 addition & 1 deletion src/ServiceFabric/ServiceFabric/help/New-AzServiceFabricCluster.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ The Operating System of the VMs that make up the cluster.
Type: Microsoft.Azure.Commands.ServiceFabric.Models.OperatingSystem
Parameter Sets: ByDefaultArmTemplate
Aliases: VmImage
Accepted values: WindowsServer2012R2Datacenter, WindowsServer2016Datacenter, WindowsServer2016DatacenterwithContainers, UbuntuServer1604, UbuntuServer1804, UbuntuServer2004
Accepted values: WindowsServer2012R2Datacenter, WindowsServer2016Datacenter, WindowsServer2016DatacenterwithContainers, UbuntuServer1604, UbuntuServer1804, UbuntuServer2004, WindowsServer2022

Required: False
Position: Named
Expand Down