-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[Az.ConnectedKubernetes] support proxy environments and fix issues #20944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Squashed commit: [37a75ce5980] Add optional settings [f90cd1a98ee] Add optional settings
…ashed commits) Squashed commits: [49e9e01caf3] Install azure-arc helm release in azure-arc-release namespace (+1 squashed commits) Squashed commits: [9662ecff989] Install azure-arc helm release in azure-arc-release namespace
Squashed commits: [28ff1d7f8cf] Add Proxy settings (+4 squashed commit) Squashed commit: [cdfe615ad63] Update warning messages [5d46ec26806] Check credential [db0351e75f5] Update parameter description [79bf2b15c29] Modify parameter type
…hed commits) Squashed commits: [c893de7a1b5] Fix Invalid URI issue when passing diaplsy name of location (+1 squashed commits) Squashed commits: [bc81f1915fb] Fix Invalid URI issue when passing diaplsy name of location
BethanyZhou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run ./build-module.ps1 to refresh docs in your local.
I expected docs/New-AzConnectedKubernetes.md refreshed with syntax changes |
Docs are renewed by ./build-module.ps1. |
|
|
||
| # Clear helm azure-arc environment | ||
| helm delete azure-arc --no-hooks | ||
| helm delete azure-arc -n azure-arc-release --no-hooks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested your command on you local?
- To run command on your local, please use
./run-module.ps1afterbuild-module.ps1 - To record test cases, remove -Skip from It 'CreateExpanded' -skip, see L15 and I'm expecting there is a json file under test folder.
Test always is the best way to ensure quality of commands. Your test case is always skipped with -Skip Tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing out this. We've tested the code with integration test and end-to-end test with the product team for GA.
I think the -Skip was there because of the test case needs pre-requisites on the environment before it started.
1.Prepare your machines for AKS Edge Essentials
2.Create a kubernetes cluster on the machine
3.Set file path for helm.exe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. I'd recommend preparing the environment in
| function setupEnv() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the dev and test env are separated at this moment.
Maybe we can enhance the test once the product have better integration with the dev machine.
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BethanyZhou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skip the test for the time being until the product have better integration with the dev machine.
|
@yinghsugn could you provide change log message for upcoming release? |
Description
Checklist
CONTRIBUTING.mdand reviewed the following information:generationbranch.ChangeLog.mdfile(s) appropriatelyChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch.ChangeLog.mdif no new release is required, such as fixing test case only.