Skip to content

Conversation

@vinhms
Copy link
Contributor

@vinhms vinhms commented May 2, 2023

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented May 2, 2023

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.CosmosDB
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ AssemblyInfo.cs will be updated automatically. Please do not update it manually. Revert AssemblyInfo.cs to its last version.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@vinhms vinhms requested review from kavskalyan and kshittiz7 May 3, 2023 16:58
@vinhms vinhms marked this pull request as ready for review May 4, 2023 04:31
msJinLei
msJinLei previously approved these changes May 5, 2023
@msJinLei msJinLei dismissed their stale review May 5, 2023 05:20

@vinhms Please improve the title of the PR

Copy link
Contributor

@msJinLei msJinLei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinhms Please improve the title of the PR

@msJinLei
Copy link
Contributor

msJinLei commented May 5, 2023

/azp run azure-powershell - security-tools

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@vinhms vinhms changed the title [Cosmos DB] Continuous 7 GA [Cosmos DB] Powershell changes for 2023-04-15 stable API (Continuous 7 GA) May 5, 2023
@ddhamotharan ddhamotharan self-requested a review May 5, 2023 17:54
Copy link
Contributor

@ddhamotharan ddhamotharan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good

@vinhms vinhms requested a review from ddhamotharan May 5, 2023 17:55
Copy link
Contributor

@ddhamotharan ddhamotharan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good

@msJinLei msJinLei merged commit 5d4d82a into Azure:main May 6, 2023
@vinhms
Copy link
Contributor Author

vinhms commented May 8, 2023

hi @msJinLei , thanks for merging the PR. I noticed that the "Milestone" is not set for this PR. Can you confirm when this change will get released? Will it be part of the June 2023 (2023-05-23) release automatically?

If not, please let us know what need to be done to have this change be part of 2023-05-23.

@msJinLei
Copy link
Contributor

hi @msJinLei Lei Jin FTE , thanks for merging the PR. I noticed that the "Milestone" is not set for this PR. Can you confirm when this change will get released? Will it be part of the June 2023 (2023-05-23) release automatically?

If not, please let us know what need to be done to have this change be part of 2023-05-23.

Will release in 2023-05-23

@vinhms vinhms mentioned this pull request May 12, 2023
1 task
wyunchi-ms pushed a commit that referenced this pull request Feb 25, 2024
* apply Az.CosmosDB-preview branch CosmosDB folder to this branch

* Use autorest.powershell to generate management SDK for cosmosDB (#22413)

* remove the custom code since character case change is not treated as a breaking change (#22500)

* regen sdk

* specify header type as string to fix build error

* update autorest file to align with main; regen sdk

* fix casing

* [Cosmos DB] Powershell changes for 2023-03-15 stable API (#21990)

* added tests for listconnectionstrings; updated changelog

* add changes for list connection strings response

* re-record test

* update changelog

* Add location api changes

* Added test recording for location api

* re-record tests

* re-record tests

* Revert "add changes for list connection strings response"

This reverts commit ff3ef0a.

* update changelog, update and re-record account tests

---------

Co-authored-by: Udit Singh <[email protected]>

* CosmosDB - New Restore Parameter (#22585)

* restore new param public network access

* minor fixes

* test change

* stable changes 1

* md param def changed

* reverting test changes for build

* restore ts

* test and test recording

* CosmosDB 2023-09-15 release (#22726) (#22953)

* genrated changes

* help and changelog and test case update

* Powershell model changes for burst capacity

* added customer managed key status to PSDatabaseAccountGetResults.cs

* added recording for MongoOperationsTests and SqlOperationsTest

* added recording for remaining tests

* rerecorded failed tests

* added changes in tests

* Minimal Tls version for create and update

* fixed build errors

* updated tls version in test

* updated commit id

* MinimalTlsVersion to changelog

* Update ChangeLog.md

Added CustomerManagedKeyStatus to the Changelog

* mask 'primaryReadOnlyMasterKey' and 'secondaryReadOnlyMasterKey' in recorded test

* mask 'primaryMasterKey' and 'secondaryMasterKey' in recorded test

* rerecorded account tests

* rerecorded account tests

* rerecorded Cassandra tests

* re-recorded all but mongo and restore tests

---------

Co-authored-by: Richa Sharma <[email protected]>
Co-authored-by: Adrián Sibaja Retana <[email protected]>
Co-authored-by: unknown <[email protected]>
Co-authored-by: AdrianSibajaRetana <[email protected]>

* [CosmosDB] GA PowerShell commands for InAccount Restore of Deleted Database/ Containers feature for SQL/Mongo/Table/Gremlin (#23666)

* changes and generated code

* update tests

* update session records

* update help files

* update changelog

* update session records

* update TestUpdateCosmosDBAccountBackupPolicyToContinuous30Days session record

* update session records

* add notimestamp tests and update few old session records

* regen sdk, fix build error

* fix duplicate code

* nit fix restore tests

* re-record tests

* CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account (#21736)

* Merge branch 'Az.CosmosDB-preview' of https://github.com/SrinikhilReddy/azure-powershell into features/users/nanarava/enablepmerge

* CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account.

* CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account.

* Update src/CosmosDB/CosmosDB/ChangeLog.md

Co-authored-by: Jin Lei <[email protected]>

* CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account.

* CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account.

* CosmosDB: Adds changes to handle enabling partition merge on CosmosDB account.

* Update ChangeLog.md

Remove duplicate line

* Resolve code comments.

---------

Co-authored-by: Jin Lei <[email protected]>

* Replace Start-Sleep with Start-TestSleep for all test cases (#23780)

* re-record account test

* fix typo

* [Cosmos DB] Powershell changes for 2023-04-15 stable API (Continuous 7 GA) (#21685)

* move to new swagger version and prereq

* edit readme.md

* manually generated from autorest

* Continuous 7 days change

* add 2 new test recordings

* fix example issues

* add all test recordings for RestoreTests suite

* fix New-AzCosmosDBAccount.md

* add almost all test recordings

* add 4 more successful recordings. all working now

* no examples

* clean up help file

* add output type to cmdlet

* suppress errors for existing cmdlets

* Revert "suppress errors for existing cmdlets"

This reverts commit f36e275.

* suppress static validation errors for existing commands

---------

Co-authored-by: Xiaogang <[email protected]>
Co-authored-by: Udit Singh <[email protected]>
Co-authored-by: mayankkatwal <[email protected]>
Co-authored-by: Yabo Hu <[email protected]>
Co-authored-by: Richa Sharma <[email protected]>
Co-authored-by: Adrián Sibaja Retana <[email protected]>
Co-authored-by: unknown <[email protected]>
Co-authored-by: AdrianSibajaRetana <[email protected]>
Co-authored-by: ddhamotharan <[email protected]>
Co-authored-by: Srinikhil Naravamakula <[email protected]>
Co-authored-by: Jin Lei <[email protected]>
Co-authored-by: Vincent Dai <[email protected]>
Co-authored-by: vinhms <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants