Skip to content

Conversation

@felixcho-work
Copy link
Contributor

@felixcho-work felixcho-work commented May 24, 2016

Hi Azure team,

Please review and merge Automation cmdlet changes. This is for the next release train of 6/1.

Thanks.

Change logs:

  • New-AzureRmAutomationRunbook and Import-AzureRmAutomationRunbook supports the new “GraphPowerShell” and “GraphPowerShellWorkflow” (recommended in place of “Graph”) types.
  • Start-AzureRmAutomationRunbook supports the -Wait parameter
  • New-AzureRmAutomationSchedule and Get-AzureRmAutomationSchedule now support weekly and monthly schedules.
  • New-AzureRmAutomationSchedule now takes a Timezone parameter to adjust for daylight savings.

Bpoe and others added 19 commits April 20, 2016 13:46
Adding Time Zone support for Get and New schedule cmdlets
1. Add "GraphPowerShell" and "GraphPowerShellWorkflow".
2. No need to force "PowerShellWorkflow" to "Script" since backend is all updated.
New Graphical Runbook types
CalendarSchedule-Adding Property bag for Monthly and WeeklySchedule Option Response
- Start-AzureRMAutomationRunbook: Wait and MaxWaitSeconds
- New/Import-AzureRMAutomationRunbook: new Type param values; mark "Graph" as obsolete
- New-AzureRMAutomationSchedule: advanced schedules
2. Added parameter mapping of GraphicalPowerShell/GraphicalPowerShellWorkflow to Graph* SDK values
3. Build reference tweaks
@azurecla
Copy link

Hi @felixcho-msft, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (felixcho). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@azuresdkci
Copy link

Can one of the admins verify this patch?

@hovsepm
Copy link
Contributor

hovsepm commented May 24, 2016

@azuresdkci add to whitelist

schedule.Frequency = ScheduleFrequency.Day;
schedule.Interval = this.DayInterval;
throw new Exception("for monthly occurrence, both day of week and occurrence need to be specified");
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this string to resources.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@hovsepm
Copy link
Contributor

hovsepm commented May 24, 2016

{

changes to this cmdlet are not covered with any test. Please add.


Refers to: src/ResourceManager/Automation/Commands.Automation/Cmdlet/NewAzureAutomationSchedule.cs:32 in a4fa899. [](commit_id = a4fa899, deletion_comment = False)

@hovsepm
Copy link
Contributor

hovsepm commented May 24, 2016

🕐

1. Removed mstest tests
2. Move exception string to resource
3. Remove an else
@markcowl
Copy link
Member

@markcowl markcowl merged commit aa4aa57 into Azure:dev May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants