[Storage] Support ORS metric GA #28505
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Object Replication Service (ORS) metrics in Azure Storage, enabling users to control whether metrics are collected for object replication policies through a new -EnableMetric parameter.
- Adds new
-EnableMetricboolean parameter to theSet-AzStorageObjectReplicationPolicycmdlet - Updates the object replication policy model to include metrics properties
- Modifies the display format to show metrics status in table output
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| SetAzStorageObjectReplicationPolicy.cs | Adds -EnableMetric parameter and logic to set metrics properties on the policy |
| PSObjectReplicationPolicy.cs | Adds metrics model class and integration with existing policy structure |
| Storage.Management.format.ps1xml | Updates table display format to include metrics enabled status column |
| Set-AzStorageObjectReplicationPolicy.md | Updates help documentation with new parameter and usage examples |
| ChangeLog.md | Documents the new metrics support feature |
| StorageBlobTests.ps1 | Updates tests to verify metrics functionality and fixes test location references |
| * Supported Enable Metrics when set object replication policy | ||
| - `New-AzStorageObjectReplicationPolicyRule` |
There was a problem hiding this comment.
The ChangeLog entry is incorrect. The feature was added to Set-AzStorageObjectReplicationPolicy, not New-AzStorageObjectReplicationPolicyRule. The cmdlet name should be corrected to match the actual changes made.
| * Supported Enable Metrics when set object replication policy | |
| - `New-AzStorageObjectReplicationPolicyRule` | |
| - `Set-AzStorageObjectReplicationPolicy` |
Copilot uses AI. Check for mistakes.
| Mandatory = false, | ||
| HelpMessage = "Indicates whether object replication metrics feature is enabled for the policy.", | ||
| ParameterSetName = AccountObjectParameterSet)] | ||
| [ValidateNotNullOrEmpty] |
There was a problem hiding this comment.
The [ValidateNotNullOrEmpty] attribute is inappropriate for a boolean parameter. This attribute is designed for string/collection validation and will cause validation errors since boolean values cannot be null or empty in this context.
| [ValidateNotNullOrEmpty] |
Copilot uses AI. Check for mistakes.
2 participants
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.