Update PSApplicationGatewayFirewallPolicyManagedRuleOverride and PSAp…

[Shaigoldbourt22]

…plicationGatewayFirewallPolicyManagedRuleSet files for consistency and clarity

Description

Mandatory Checklist

• Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)

  • General release
  • Public preview
  • Private preview
  • Engineering build
  • No need for a release

• Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

• SHOULD update ChangeLog.md file(s) appropriately
  • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
  • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
• SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
• SHOULD have proper test coverage for changes in pull request.
• SHOULD NOT adjust version of module manually in pull request

[azure-client-tools-bot-prd]

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

[Copilot]

Pull Request Overview

This PR adds new properties to Azure Application Gateway Firewall Policy models to enhance consistency and clarity. The changes introduce DisplayName and ParanoiaLevel properties to the respective PowerShell model classes.

• Added DisplayName property to PSApplicationGatewayFirewallPolicyManagedRuleSet
• Added ParanoiaLevel property to PSApplicationGatewayFirewallPolicyManagedRuleOverride

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
PSApplicationGatewayFirewallPolicyManagedRuleSet.cs	Added DisplayName property with private setter and Ps1Xml attribute for table display
PSApplicationGatewayFirewallPolicyManagedRuleOverride.cs	Added ParanoiaLevel property with Ps1Xml attribute for table display

[Copilot]

The DisplayName property has a private setter which makes it read-only from external code. Consider whether this property should allow external modification or if there should be a constructor parameter or internal method to set this value. Without a way to populate this property, it will always be null.

[isra-fel]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[VeryEarly]

• have you considered pushing this change to https://github.com/Azure/azure-powershell/tree/release-network-2024-10-01 to follow the NRP release?
• are these 2 properties readonly? If not, please expose them in cmdlet for user to set
• please add proper test coverage
• please update https://github.com/Shaigoldbourt22/azure-powershell/blob/shai/test_pr/src/Network/Network/ChangeLog.md, write release note right under upcoming release section

[isra-fel]

Closing the PR for lack of activity. Feel free to reopen to continue working on it. Thanks 😀