Skip to content

Conversation

yifanz7
Copy link
Member

@yifanz7 yifanz7 commented Sep 17, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings September 17, 2025 05:15
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the EnableSmbOAuth parameter to the New-AzStorageAccount and Set-AzStorageAccount cmdlets, allowing users to configure whether managed identities can access SMB shares using OAuth authentication when creating or updating storage accounts.

  • Adds new EnableSmbOAuth parameter to both cmdlets with appropriate validation and help text
  • Implements support for the SMB OAuth settings in the Azure Files identity-based authentication configuration
  • Updates the PowerShell model classes to include SMB OAuth settings support

Reviewed Changes

Copilot reviewed 52 out of 99 changed files in this pull request and generated no comments.

Show a summary per file
File Description
SetAzureStorageAccount.cs Adds EnableSmbOAuth parameter and implementation for updating storage accounts
NewAzureStorageAccount.cs Adds EnableSmbOAuth parameter and implementation for creating storage accounts
PSAzureFilesIdentityBasedAuthentication.cs Adds PSSmbOAuthSettings model class and integration
ChangeLog.md Documents the new feature in the changelog
Test session recordings Updates API version references from 2024-01-01 to 2025-01-01
Comments suppressed due to low confidence (3)

@yifanz7 yifanz7 marked this pull request as draft September 17, 2025 05:17
@yifanz7 yifanz7 marked this pull request as ready for review September 17, 2025 05:33
@VeryEarly VeryEarly self-assigned this Sep 17, 2025
@VeryEarly VeryEarly merged commit 23609db into Azure:main Sep 17, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants