Skip to content

Fix RoleAssignment ObjectType fallback for insufficient MSGraph permissions #28584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 19, 2025
Merged

Fix RoleAssignment ObjectType fallback for insufficient MSGraph permissions #28584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e64ca77
Initial plan
Copilot Sep 18, 2025
f64066a
Fix RoleAssignment ObjectType fallback for insufficient MSGraph permi…
Copilot Sep 18, 2025
56c9d2b
Address PR feedback: revert main ChangeLog.md and test changes, updat…
Copilot Sep 18, 2025
e378a90
Simplify changelog entry for RoleAssignment cmdlets
isra-fel Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Resources/Resources/ChangeLog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
-->

## Upcoming Release
* Fixed issue where RoleAssignment cmdlets did not properly handle insufficient MSGraph permissions [#28583]

## Version 8.1.0
* Added functionality for cmdlet `GetAzureResourceGroup`[#27865]
Expand Down
6 changes: 4 additions & 2 deletions src/Resources/Resources/Models.Authorization/AuthorizationClientExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,9 @@ public static PSRoleAssignment ToPSRoleAssignment(this RoleAssignment assignment
{
if (oe.IsAuthorizationDeniedException() || oe.IsNotFoundException())
{
adObject = new PSADObject() { Id = assignment.PrincipalId, Type = UnknownType};
// fall back to cached principal type from response,
// then finally fall back to "Unknown"
adObject = new PSADObject() { Id = assignment.PrincipalId, Type = assignment.PrincipalType ?? UnknownType};
}
//Swallow exceptions when displaying active directive object
}
Expand Down Expand Up @@ -197,7 +199,7 @@ public static IEnumerable<PSRoleAssignment> ToPSRoleAssignments(this IEnumerable
foreach (RoleAssignment assignment in assignments)
{
assignment.RoleDefinitionId = assignment.RoleDefinitionId.GuidFromFullyQualifiedId();
PSADObject adObject = adObjects.SingleOrDefault(o => o.Id == assignment.PrincipalId) ?? new PSADObject() { Id = assignment.PrincipalId, Type = UnknownType };
PSADObject adObject = adObjects.SingleOrDefault(o => o.Id == assignment.PrincipalId) ?? new PSADObject() { Id = assignment.PrincipalId, Type = assignment.PrincipalType ?? UnknownType };
PSRoleDefinition roleDefinition = roleDefinitions.SingleOrDefault(r => r.Id == assignment.RoleDefinitionId) ?? new PSRoleDefinition() { Id = assignment.RoleDefinitionId };
var psRoleAssignment = new PSRoleAssignment()
{
Expand Down