-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Adding SupportedSecurityOption for Trusted Launch as Default #28677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds the SupportedSecurityOption
parameter to the New-AzDiskConfig
cmdlet to enable creation of Azure managed disks with Trusted Launch or Confidential VM security capabilities. This addresses a design request for supporting security options on disk creation.
- Added
SupportedSecurityOption
parameter toNew-AzDiskConfig
cmdlet with support for 'TrustedLaunchSupported' and 'TrustedLaunchAndConfidentialVMSupported' values - Implemented comprehensive test coverage for the new parameter functionality
- Updated documentation with usage examples and parameter descriptions
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/Compute/Compute/help/New-AzDiskConfig.md | Added documentation for SupportedSecurityOption parameter and usage example |
src/Compute/Compute/ChangeLog.md | Added changelog entry for the new parameter |
src/Compute/Compute.Test/ScenarioTests/DiskRPTests.ps1 | Added PowerShell test function to validate SupportedSecurityOption functionality |
src/Compute/Compute.Test/ScenarioTests/DiskRPTests.cs | Added C# test method to execute the PowerShell test |
@microsoft-github-policy-service agree company="Microsoft" |
Co-authored-by: Copilot <[email protected]>
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@DanielMicrosoft can you review this PR please? |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@microsoft-github-policy-service agree company="Microsoft" |
@microsoft-github-policy-service rerun |
Need to confirm one more thing with the feature team |
|
Description
Adding the parameter SupportedSecuirtyOption to New-AzDiskConfig and New-DiskUpdateConfig as requested by this design: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1501
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.