Skip to content

Conversation

audreyttt
Copy link
Member

Description

Adding the parameter SupportedSecuirtyOption to New-AzDiskConfig and New-DiskUpdateConfig as requested by this design: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1501

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the SupportedSecurityOption parameter to the New-AzDiskConfig cmdlet to enable creation of Azure managed disks with Trusted Launch or Confidential VM security capabilities. This addresses a design request for supporting security options on disk creation.

  • Added SupportedSecurityOption parameter to New-AzDiskConfig cmdlet with support for 'TrustedLaunchSupported' and 'TrustedLaunchAndConfidentialVMSupported' values
  • Implemented comprehensive test coverage for the new parameter functionality
  • Updated documentation with usage examples and parameter descriptions

Reviewed Changes

Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.

File Description
src/Compute/Compute/help/New-AzDiskConfig.md Added documentation for SupportedSecurityOption parameter and usage example
src/Compute/Compute/ChangeLog.md Added changelog entry for the new parameter
src/Compute/Compute.Test/ScenarioTests/DiskRPTests.ps1 Added PowerShell test function to validate SupportedSecurityOption functionality
src/Compute/Compute.Test/ScenarioTests/DiskRPTests.cs Added C# test method to execute the PowerShell test

@audreyttt
Copy link
Member Author

@microsoft-github-policy-service agree company="Microsoft"

Co-authored-by: Copilot <[email protected]>
@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

@DanielMicrosoft can you review this PR please?

@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@audreyttt
Copy link
Member Author

@microsoft-github-policy-service agree company="Microsoft"

@isra-fel
Copy link
Member

@microsoft-github-policy-service rerun

@audreyttt
Copy link
Member Author

Need to confirm one more thing with the feature team

Copy link

‼️ DO NOT MERGE THIS PR ‼️
This PR was labeled "Do Not Merge" because it contains code change that cannot be merged. Please contact the reviewer for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants