-
Notifications
You must be signed in to change notification settings - Fork 4.1k
[SignalR] Add cmdlets to managing replicas and IP rules #28684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive cmdlets for managing SignalR replicas and network IP rules for Azure SignalR Service. It introduces replica management capabilities (create, get, update, start, stop, restart, remove) and network ACL IP rule management for Premium SignalR services.
- Adds 7 replica management cmdlets supporting multiple parameter sets and full CRUD operations
- Adds 3 network IP rule cmdlets for creating rule objects and adding/removing IP rules
- Updates existing help documentation and adds comprehensive test coverage
Reviewed Changes
Copilot reviewed 37 out of 46 changed files in this pull request and generated 7 comments.
Show a summary per file
File | Description |
---|---|
help/*.md files | New help documentation for all replica and IP rule cmdlets |
Cmdlets/Replica/*.cs | Implementation of 7 replica management cmdlets with full parameter set support |
Cmdlets/AddAzureRmSignalRNetworkIpRule.cs | Add IP rules to SignalR network ACLs |
Cmdlets/RemoveAzureRmSignalRNetworkIpRule.cs | Remove IP rules from SignalR network ACLs |
Cmdlets/NewAzureRmSignalRNetworkIpRuleObject.cs | Create IP rule objects for network ACL operations |
Models/*.cs | New model classes for replica resources and IP rules |
Test files | Comprehensive test coverage for all new functionality |
Az.SignalR.psd1 | Module manifest updates to export new cmdlets |
ChangeLog.md | Documentation of new features |
``` | ||
|
||
### -ProgressAction | ||
{{ Fill ProgressAction Description }} |
Copilot
AI
Oct 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ProgressAction parameter description is incomplete. It should provide a meaningful description about how PowerShell handles progress updates for the cmdlet.
{{ Fill ProgressAction Description }} | |
Specifies how the cmdlet responds to progress updates. By default, progress information is displayed. You can use this parameter to suppress or customize the display of progress messages. Valid values are `SilentlyContinue`, `Continue`, `Stop`, `Inquire`, `Ignore`, `Suspend`, and `Break`. For more information, see [about_CommonParameters](https://learn.microsoft.com/powershell/module/microsoft.powershell.core/about/about_commonparameters). |
Copilot uses AI. Check for mistakes.
``` | ||
|
||
### -ProgressAction | ||
{{ Fill ProgressAction Description }} |
Copilot
AI
Oct 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ProgressAction parameter description is incomplete. It should provide a meaningful description about how PowerShell handles progress updates for the cmdlet.
{{ Fill ProgressAction Description }} | |
Specifies how the cmdlet responds to progress updates. By default, progress is displayed. You can use this parameter to silently continue, stop, or suppress progress messages during the operation. |
Copilot uses AI. Check for mistakes.
``` | ||
|
||
### -ProgressAction | ||
{{ Fill ProgressAction Description }} |
Copilot
AI
Oct 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ProgressAction parameter description is incomplete. It should provide a meaningful description about how PowerShell handles progress updates for the cmdlet.
{{ Fill ProgressAction Description }} | |
Specifies how PowerShell responds to progress updates generated by the cmdlet. By default, progress is displayed, but you can use this parameter to suppress or customize progress reporting (for example, by setting it to SilentlyContinue to hide progress). |
Copilot uses AI. Check for mistakes.
``` | ||
|
||
### -ProgressAction | ||
{{ Fill ProgressAction Description }} |
Copilot
AI
Oct 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ProgressAction parameter description is incomplete. It should provide a meaningful description about how PowerShell handles progress updates for the cmdlet.
{{ Fill ProgressAction Description }} | |
Specifies how the cmdlet responds to progress updates. By default, progress is shown. You can use this parameter to control whether progress information is displayed, hidden, or handled in another way. Acceptable values are `SilentlyContinue`, `Continue`, `Stop`, `Inquire`, and `Ignore`. |
Copilot uses AI. Check for mistakes.
``` | ||
|
||
### -ProgressAction | ||
{{ Fill ProgressAction Description }} |
Copilot
AI
Oct 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ProgressAction parameter description is incomplete. It should provide a meaningful description about how PowerShell handles progress updates for the cmdlet.
{{ Fill ProgressAction Description }} | |
Specifies how the cmdlet responds to progress updates. By default, progress is shown. You can use this parameter to control whether progress information is displayed, silently continued, or suppressed (for example, by setting to 'SilentlyContinue'). |
Copilot uses AI. Check for mistakes.
``` | ||
|
||
### -ProgressAction | ||
{{ Fill ProgressAction Description }} |
Copilot
AI
Oct 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ProgressAction parameter description is incomplete. It should provide a meaningful description about how PowerShell handles progress updates for the cmdlet.
{{ Fill ProgressAction Description }} | |
Specifies how PowerShell responds to progress updates for the cmdlet. You can use this parameter to control whether progress bars are displayed, hidden, or handled in a specific way. Acceptable values are 'SilentlyContinue', 'Continue', 'Stop', 'Inquire', 'Ignore', 'Suspend', or 'Break'. |
Copilot uses AI. Check for mistakes.
``` | ||
|
||
### -ProgressAction | ||
{{ Fill ProgressAction Description }} |
Copilot
AI
Oct 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ProgressAction parameter description is incomplete. It should provide a meaningful description about how PowerShell handles progress updates for the cmdlet.
{{ Fill ProgressAction Description }} | |
Specifies how the cmdlet responds to progress updates. By default, progress is shown. Use 'SilentlyContinue' to suppress progress output. For more information, see [about_CommonParameters](http://go.microsoft.com/fwlink/?LinkID=113216). |
Copilot uses AI. Check for mistakes.
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.