-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Added Client IP Preservation properties to Application Gateway model #28685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Client IP Preservation properties to Application Gateway model #28685
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for client IP preservation in Azure Application Gateway by introducing two new properties: EnableL4ClientIpPreservation
for backend settings and EnableProbeProxyProtocolHeader
for probe configurations. These properties enable the Application Gateway to send proxy protocol headers to backend servers and health probes respectively.
Key changes:
- Added new boolean properties to PowerShell models for proxy protocol header support
- Updated cmdlet parameters and help documentation for backend settings and probe configurations
- Implemented default value handling (false) when parameters are not provided
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
PSApplicationGatewayProbe.cs | Added EnableProbeProxyProtocolHeader property to probe model |
PSApplicationGatewayBackendSettings.cs | Added EnableL4ClientIpPreservation property to backend settings model |
AzureApplicationGatewayProbeConfigBase.cs | Implemented parameter handling and default value logic for probe proxy protocol |
AzureApplicationGatewayBackendSettingsBase.cs | Implemented parameter handling and default value logic for client IP preservation |
Help files (6 files) | Updated cmdlet documentation to include new parameter descriptions |
ChangeLog.md | Documented the new features and affected cmdlets |
src/Network/Network/help/New-AzApplicationGatewayBackendSetting.md
Outdated
Show resolved
Hide resolved
…g.md Co-authored-by: Copilot <[email protected]>
/azp run |
Commenter does not have sufficient privileges for PR 28685 in repo Azure/azure-powershell |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
The check is behaving weirdly. Let me close and reopen |
It's the same. @akshimittal1310 can you try the instructions above? |
@microsoft-github-policy-service agree company="Microsoft" |
Description
This PR adds support for sending proxy protocol headers to backends over TCP and TLS protocols in the Application Gateway Backend Settings and Probe PowerShell models and cmdlets.
Introduced EnableL4ClientIpPreservation and EnableProbeProxyProtocolHeader properties in the PS model class.
Updated the Help section for new properties for each cmdlet (Set, Get and Add)
Added details in ChangeLog file
Ensured default values align with the API spec when parameters are not provided.
Swagger PR to add these properties is already merged
https://github.com/Azure/azure-rest-api-specs/pull/37340/files
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.