Skip to content

Conversation

akshimittal1310
Copy link
Contributor

@akshimittal1310 akshimittal1310 commented Oct 14, 2025

Description

This PR adds support for sending proxy protocol headers to backends over TCP and TLS protocols in the Application Gateway Backend Settings and Probe PowerShell models and cmdlets.

Introduced EnableL4ClientIpPreservation and EnableProbeProxyProtocolHeader properties in the PS model class.
Updated the Help section for new properties for each cmdlet (Set, Get and Add)
Added details in ChangeLog file
Ensured default values align with the API spec when parameters are not provided.
Swagger PR to add these properties is already merged
https://github.com/Azure/azure-rest-api-specs/pull/37340/files

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for client IP preservation in Azure Application Gateway by introducing two new properties: EnableL4ClientIpPreservation for backend settings and EnableProbeProxyProtocolHeader for probe configurations. These properties enable the Application Gateway to send proxy protocol headers to backend servers and health probes respectively.

Key changes:

  • Added new boolean properties to PowerShell models for proxy protocol header support
  • Updated cmdlet parameters and help documentation for backend settings and probe configurations
  • Implemented default value handling (false) when parameters are not provided

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
PSApplicationGatewayProbe.cs Added EnableProbeProxyProtocolHeader property to probe model
PSApplicationGatewayBackendSettings.cs Added EnableL4ClientIpPreservation property to backend settings model
AzureApplicationGatewayProbeConfigBase.cs Implemented parameter handling and default value logic for probe proxy protocol
AzureApplicationGatewayBackendSettingsBase.cs Implemented parameter handling and default value logic for client IP preservation
Help files (6 files) Updated cmdlet documentation to include new parameter descriptions
ChangeLog.md Documented the new features and affected cmdlets

@akshimittal1310
Copy link
Contributor Author

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 28685 in repo Azure/azure-powershell

@kamboj-prjwl kamboj-prjwl requested a review from isra-fel October 14, 2025 10:20
@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel isra-fel enabled auto-merge (squash) October 15, 2025 00:17
@isra-fel
Copy link
Member

The check is behaving weirdly. Let me close and reopen

@isra-fel isra-fel closed this Oct 15, 2025
auto-merge was automatically disabled October 15, 2025 02:01

Pull request was closed

@isra-fel isra-fel reopened this Oct 15, 2025
@isra-fel
Copy link
Member

It's the same. @akshimittal1310 can you try the instructions above?

@isra-fel isra-fel enabled auto-merge (squash) October 15, 2025 02:02
@akshimittal1310
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@isra-fel isra-fel merged commit e36b0a9 into Azure:release-network-2025-01-01 Oct 15, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants