Liftr Elastic PS cmdlets for stable version 2025-06-01 #28705
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure Elastic PowerShell cmdlets to support the stable API version 2025-06-01, introducing new capabilities for monitored subscriptions, OpenAI connector management, and enhanced monitor resource configuration options.
Key Changes
- Updated API version from 2024-03-01 to 2025-06-01 across all cmdlets
- Added new cmdlets for managing monitored subscriptions (Get/Update/Remove-AzElasticMonitoredSubscription)
- Added cmdlet for organization resubscription (Get-AzElasticResubscribeOrganization)
- Enhanced OpenAI integration with new OpenAiConnectorId parameter
- Added new monitor properties: HostingType, Kind, ProjectDetail configuration
Reviewed Changes
Copilot reviewed 116 out of 119 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| help/*.md (22 files) | Updated cmdlet documentation with enhanced descriptions and new parameter documentation |
| Az.Elastic.psd1 | Updated module manifest with new cmdlet exports and Az.Accounts dependency to 5.3.0 |
| test/*.ps1 (7 files) | Added/updated test files for new cmdlets and modified test environment setup to use existing resources |
| test/*.Recording.json (10 files) | Updated test recording files with new API version and response payloads |
| test/utils.ps1 | Modified test setup to use existing Elastic monitors instead of creating new ones |
| test/env.json | Updated test environment configuration with new resource details |
| Elastic.sln | Updated project GUID reference |
| generate-info.json | Updated generation identifier |
Co-authored-by: Copilot <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| Get-AzElasticResubscribeOrganization -MonitorName <String> -ResourceGroupName <String> | ||
| [-SubscriptionId <String[]>] [-OrganizationId <String>] [-PlanId <String>] [-ResourceGroup <String>] | ||
| [-TargetSubscriptionId <String>] [-Term <String>] [-DefaultProfile <PSObject>] [-AsJob] [-NoWait] | ||
| [-WhatIf] [-Confirm] [<CommonParameters>] |
There was a problem hiding this comment.
Why -WhatIf and -Confirm for a GET command? Normally they are necessary if the command has side effects.
Consider hiding them if the command does not have side effects, or renaming the command if it has.
There was a problem hiding this comment.
Not required, removed them
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 28705 in repo Azure/azure-powershell |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
There are still a bunch of [-whatif] appearing in Get- commands which are not supposed to have side effects. Check out https://github.com/Azure/autorest.powershell/blob/main/docs/directives.md#Suppress-ShouldProcess for more details and guidance
That's the only thing left
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
2 participants
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.