Add DisableVMAgent parameter to Set-AzureRmVMOperatingSystem cmdlet #5889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@hyonholee Provision / Disable VM Agent should be mutually exclusive by parameter set. Also, please assign the appropriate milestone. |
Contributor
Author
|
@markcowl I updated the PR by adding two additional parameter sets so that Provision and Disable Agent are mutually exclusive. Thanks. |
cormacpayne
reviewed
Apr 10, 2018
Member
There was a problem hiding this comment.
@hyonholee is this else block necessary? It looks like we just need the if and else-if blocks
Contributor
Author
|
@markcowl could you merge if there is no more concern? Thanks. |
markcowl
approved these changes
Apr 18, 2018
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the following issue:
#5838
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/42
Description
Add DisableVMAgent parameter to Set-AzureRmVMOperatingSystem cmdlets, and fix the behavior when neither ProvisionVMAgent nor DisableVMAgent are given.
Checklist
CONTRIBUTING.mdplatyPSmodule