Skip to content

Conversation

@SudhakaraReddyEvuri-zz
Copy link

@SudhakaraReddyEvuri-zz SudhakaraReddyEvuri-zz commented Apr 10, 2018

Description

Checklist

@SudhakaraReddyEvuri-zz
Copy link
Author

These changes to AzureDiskEncryption pre-requisites sample script enable soft delete and add resource lock on KeyVault . This will show an example on how to prevent accidental deletion of encryption secrets in customers key vault.

@cormacpayne
Copy link
Member

@SudhakaraReddyEvuri what kind of validation is done around this script? I remembered we previously talked about having this script tested in some fashion, we just want to ensure that the functionality being added is being tested and validated

Copy link
Member

@cormacpayne cormacpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SudhakaraReddyEvuri as a general note, I think it would be nice if we added a #requires statement at the top of this file so users know they need modules outside of AzureRM.Compute to run this script (such as AzureRM.KeyVault and AzureRM.Resources). This will prevent users from getting into the situation where the script fails because it cannot find a cmdlet rather than failing instantly because they don't have all of the necessary modules on their machine.

@cormacpayne cormacpayne assigned ejarvi and unassigned cormacpayne Apr 13, 2018
@cormacpayne cormacpayne merged commit dec9bf4 into Azure:preview Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants