KeyVault: adding support for specifying key size on creation #5963
Conversation
|
|
||
| internal PSKeyVaultKeyAttributes(bool? enabled, DateTime? expires, DateTime? notBefore, string keyType, | ||
| string[] keyOps, Hashtable tags) | ||
| internal PSKeyVaultKeyAttributes(bool? enabled, DateTime? expires, DateTime? notBefore, string keyType, string[] keyOps, Hashtable tags) |
There was a problem hiding this comment.
Did you mean to change this to include the size?
There was a problem hiding this comment.
No, this is intentional. The size remains strictly a creation-time parameter, and is not captured in any client-side data type. This matches the behavior of the SDK, REST API and the service, respectively.
maddieclayton
left a comment
maddieclayton
left a comment
There was a problem hiding this comment.
Two small comments.
| ``` | ||
| ### -InRemovedState | ||
| Permanently remove the previously deleted managed storage account.```yaml |
There was a problem hiding this comment.
Move this onto a new line.
There was a problem hiding this comment.
Thanks, fixed. Not sure why platyPs generates this on the same line.
| /// </summary> | ||
| [Parameter(Mandatory = false, | ||
| HelpMessage = "Permanently remove the previously deleted managed storage account.")] | ||
| public SwitchParameter InRemovedState { get; set; } |
There was a problem hiding this comment.
Are you planning to do this for ManagedStorageSasDefinition as well?
There was a problem hiding this comment.
No, sas definitions are considered aspects of a composite entity (the managed storage account), and thus can't be deleted/purged independently of the parent object - that is, the service itself enforces this behavior.
…Remove-StorageAccount
4 participants
Description
Allowing the specification of key size on creation.
Checklist
CONTRIBUTING.mdplatyPSmodule