Dependency fix : ServiceFabric #5971

praries880 · 2018-04-17T18:15:57Z

Removing dependency of Service Fabric on public SDKs, instead moving the dependencies to the common code.

issue : #5365

Dependency fixes for ServiceFabric in this commit

…nto dependency_fix

praries880 · 2018-04-17T18:29:01Z

sign job : https://azuresdkci.westus2.cloudapp.azure.com/job/ps-sign/434/

praries880 · 2018-04-17T20:53:44Z

new sign job : https://azuresdkci.westus2.cloudapp.azure.com/job/ps-sign/435/

cormacpayne

@praries880 same comments for you to take a look at

cormacpayne · 2018-04-18T16:33:41Z

src/Common/Commands.Common.Keyvault/Commands.Common.Keyvault.csproj

+    <ProjectGuid>{836965C0-B198-4D01-B3D7-757DB62B49A0}</ProjectGuid>
+    <OutputType>Library</OutputType>
+    <AppDesignerFolder>Properties</AppDesignerFolder>
+    <RootNamespace>Microsoft.Azure.Commands.Common.Keyvault</RootNamespace>


@praries880 if possible, can we change the name from Keyvault to KeyVault for consistency?

cormacpayne · 2018-04-18T16:35:43Z

src/Common/Commands.Common.Keyvault/Common.Keyvault.Netcore.csproj

+
+  <PropertyGroup>
+    <TargetFramework>netcoreapp2.0</TargetFramework>
+    <AssemblyName>Microsoft.WindowsAzure.Commands.Common.Keyvault</AssemblyName>


@praries880 this should be Microsoft.Azure.Commands.Common.KeyVault

I aped this off storage will fix it in my project... what about storage though?

cormacpayne · 2018-04-18T16:44:54Z

src/Common/Commands.Common.Storage/Commands.Common.Storage.csproj

+    </Reference>
  </ItemGroup>
  <ItemGroup>
+    <Compile Include="Generated.Version2017-10-01\IOperations.cs" />


@praries880 currently the Commands.Common.Storage project contains adapters around different versions of the Storage data plane SDK (WindowsAzure.Storage), so I'm not sure if we want to put generated management SDK code into this project. We should talk to Mark about what the right location for this code is (this project or a separate project)

@praries880 talked to Mark -- we should create a new project Commands.Common.Storage.Management and throw this generated code into that new project

cormacpayne · 2018-04-18T16:47:40Z

src/Common/Commands.Common.Keyvault/Commands.Common.Keyvault.csproj

+    <Reference Include="System.Net.Http" />
+  </ItemGroup>
+  <ItemGroup>
+    <Compile Include="Generated.Version2016-10-1\IKeyVaultManagementClient.cs" />


@praries880 we should follow the same pattern as the other common code projects with (potentially) multiple API versions by having a structure like the following:

Commands.Common.KeyVault

2016-10-01

Models

Model1.cs

Model2.cs

...

Operations1.cs

Operations2.cs

...

Properties

AssemblyInfo.cs

Commands.Common.KeyVault.Netcore.csproj

Commands.Common.KeyVault.csproj

MSSharedLibKey.snk

src/ResourceManager/ServiceFabric/ServiceFabric.sln

 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Commands.Common.Compute", "..\..\Common\Commands.Common.Compute\Commands.Common.Compute.csproj", "{F6D508D1-BE2D-475D-AA0F-DFB5C615CC9D}"
 EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Commands.Common.Keyvault", "..\..\Common\Commands.Common.Keyvault\Commands.Common.Keyvault.csproj", "{836965C0-B198-4D01-B3D7-757DB62B49A0}"


…nto dependency_fix

cormacpayne · 2018-04-19T22:06:40Z

src/Common/Commands.Common.Keyvault/Common.Keyvault.Netcore.csproj

+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Microsoft.Rest.ClientRuntime.Azure.Authentication" Version="2.2.12" />


@praries880 you'll want to remove this line since this package is pulled in from the Common.Netcore.Dependencies.targets file

cormacpayne · 2018-04-19T22:09:22Z

@praries880 the Jenkins build is failing because the assemblies you are adding to the project (Microsoft.Azure.Commands.Common.KeyVault.dll and Microsoft.Azure.Commands.Common.Storage.Management.dll) aren't in the list of RequiredAssemblies for Profile (you'll also want to add it to the Netcore .psd1 too)

…nto dependency_fix

praries880 · 2018-04-19T23:20:13Z

sign job : https://azuresdkci.westus2.cloudapp.azure.com/job/ps-sign/455/

cormacpayne · 2018-04-19T23:42:34Z

src/ResourceManager/ServiceFabric/Commands.ServiceFabric/Commands.ServiceFabric.Netcore.csproj

    <ProjectReference Include="..\..\..\Common\Commands.Common.Authentication.Abstractions\Common.Authentication.Abstractions.Netcore.csproj" />
    <ProjectReference Include="..\..\..\Common\Commands.Common.Graph.RBAC\Common.Rbac.Netcore.csproj" />
    <ProjectReference Include="..\..\..\Common\Commands.Common\Common.Netcore.csproj" />
+    <ProjectReference Include="..\..\..\Common\Commands.Common.Keyvault\Common.Keyvault.Netcore.csproj" />


@praries880 I believe the build is failing because of capitalization -- Keyvault vs. KeyVault ☺️

maddieclayton · 2018-05-23T00:29:39Z

sign job here: https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/642/

praries880 · 2018-05-23T15:18:37Z

sign job : https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/649/

praries880 · 2018-05-23T17:15:53Z

new sign job : https://azuresdkci.westus2.cloudapp.azure.com/view/PowerShell/job/ps-sign/656/

…nto dependency_fix

cormacpayne · 2018-05-23T22:38:58Z

@praries880 you can either rebase this PR (outlined in this doc), or we can squash the commits before merging this PR in

praries880 · 2018-05-23T22:45:55Z

@cormacpayne I'll squash the commits when I merge the PR

* #1443089: New Powershell commandlets for feature:P2S Ipsec custom policy set on Gateway. and fix build merge errors. * #1443089: Update change log * fix in AzureRM.Network.psd1 * Fix for issue #5365 Moved the Websites dependency of LogicApp into commons * Add websites dll to required assemblies part of Profile * Fic sln files to include the dependencies * Fic dependency paths and projects * Fix dll name * Add/update help files for PS command lets * Incorporate code review comments * Add csproj files for the new common module to Profile * Fix build * Fix dll name (WebSites -> Websites) in the pofile psd1 * Record failing tests * Enabled using network watcher by location * update OutputType in cmdlet * add New-AzureRMNetworkWatcherProtocolConfiguration * fix idictionary issue for header * record network watcher test * [Maps] Rename folders and files from LocationBasedServices * [Maps] Rename help file names * [Maps] Renaming variables, strings, descriptions, etc. * update help docs for New-AzureRmNetworkWatcherProtocolConfiguration * Add -ExtendedProperty parameter to New-AzureService and Set-AzureService cmdlets * Modify Commands.Sql.csproj and Commands.Sql.Test.csproj to use local update Management.Sql.dll binary for now * adding new parameters for create/update elastic pool and database cmdlets. update related db/elastic pool create/update tests * Fix issue in composing PUT request body for database and pool -- Sku object null scenario * Update elasticPool adaptor and communicator to using new sdk when trying to get databases inside a pool (Get-AzureRmSqlElasticPoolDatabase) * Update database replication related models and services to use new autorest sdk (instead of Legacy sdk) to do database copy/secondary, etc. Rerecord all replication related tests * address comments on database/elastic pool cmdlets-- null check, remove commentout codes, etc * address comments. Used -Edition -RequestedServiceObjectiveName for vcore database/pool. Only add new parameter -Vcore to specify vcore number. Modify the database replications, database restore related communicator to use new database webapi * used the published SDK 1.14.0-preview. Update LocationCapabilities model to use new API version (2017 version). Re-record LocationCapability tests * Update all db creation related cmdlets to support vcore database * Update db/elasticpool creation/update tests * Add functions to get skuname when given tier for database and pool, to avoid duplicate codes in cmdlets * use dictionary to mapping tier to skuname * re-record tests and update help file * Update restore cmdlet. Re-recording LTR restore test. Update changeLog. * address comments. and revert all changes related with 'replication links' * using published sdk 1.15.0-preview for the build issue. * Update cmds for creating/updating elasticpool. Use Patch way to do pool update inorder to support correct behaviors for updating pool * fix the yaml trailing issue in help files * Add the removed properties back in DatabaseModel and ElasticPoolModel to avoid breaking changes. And add Edition to BreakingChangeIssue exception * Update BreakingChangeIssues.csv * Address comments. Re-recording part of the failed tests in CI build * re-recording part of the failed tests in CI build. * add new tests records to output dic * link website for New-AzureRmNetworkWatcherProtocolConfiguration.md * re-record backup LTR v2 tests, AuditingClassicStorageTests, ThreatDetectionclassicStorageTests * re-record tests related with ClassicStorage * Fix test TestExportDatabase and re-record it. * fix issue with network watcher md files * Recorded and enabled skipped tests * Add StaticAnalysis checks for - No output type - Optional positional parameters - Parameter set names containing a space - Cmdlets with no default parameter set name and multiple sets * Update BreakingChangeIssues.csv * Record auditing & threat detection tests * Skip severel tests that can only run in live mode (talked with test owner). * Add tests for new static analysis checks * [Maps] Use Maps SDK over LocationBasedServices SDK * Update AzureRM.Network.psd1 * Update New-AzureRmNetworkWatcherProtocolConfiguration.md * make protocol required * Record and enable skipped Brooklyn tests to have test coverage * fix test * move from on demand to regular build * #Fix help file error * address comments. Remove Sku and PerDatabaseSettings from DatabaseModel and ElasticPoolModel.Modify the database and elastic pool response for powershell. * Fix static analysis errors * Update the elastic pool tests. fix bug. * Fix cred scan errors * Fix cred scan errors * Address comments. ReplicationLinkModel, DatabaseCopyModel, remove duplication null check and incorrect help message. * Add dependence in the ServiceManagement sln to fix the sign job * Update SignatureIssues.csv * Add default parameter set for two cmdlets. Update ChangeLog.md and remove unnecessary package files * small type fix * fix breaking change issue and signature issue * Small fix. Use SkuName in the pool model to keep alignment with other models. Rerecord related pool tests * Incorporate code review comments * Updating Networking tests with owner attributes * Fix command output * Revert "Fix command output" This reverts commit a4bace3. * Suppress signature issues as they are approved by Powershell team * Update ChangeLog.md * Update NewAzureNetworkWatcherProtocolConfiguration.cs * Fix to `New-AzureRmAks` help text. * Fix issue with Clear-AzureRmContext where old default context name was being used for empty context * Strategies library: Version 4, new WriteWarning method. * Websites.Strategies are replaced by Common.Strategies library. * Added comments with full team names * update cmdlets based on autorest .net client 2018-01-01 * Refactor InputObject variables and other review comments * get identity properties from InputObject and allow override by parameters * Skip failing Batch tests in on-demand build (see issue #5006) * Update SignatureIssues.csv * Cleanup dependencies and assembly references * remove one more reference * Update modules for 6.1.0 release * Fix error in paths for Profile RequiredAssemblies * Fix for empty examples. * [Maps] Add legacy ResourceManager & update test recordings * [Maps] Add legacy ResourceManager & update test recordings * Add example to Stop-AzureRmResourceGroupDeployment.md * [Maps] Resolving merge revision requests * [Maps] Resolving merge revision requests (2) * Remove spaces in location before comparision * Update Stack.sln * [Maps] Add PassThru to Remove method, resolve build failure * Update azure-powershell-developer-guide.md * [Maps] Update help files to reflect -PassThru param addition * [Maps] Fix trailing yaml string for PassThru * address comments * Fix local build issues because of a netcore sln file introduced accidentally * Update azure-powershell-developer-guide.md * Update test for test-ConnectivityTroubleshoot * Dependency fix : ServiceFabric (#5971) * Fix for #535 Dependency fixes for ServiceFabric in this commit * Add signing stuff and netcode projects to fix netcore build. * Added exception for breaking changes * Update all the sln projects with the newest Keyvault common project * Took care of Cormac's comments * Fix bad merge * Fix breaking build as oer comments from Cormac * Fix file name * Fix sln files for new dependencies * Fix netcore csproj * Fic netcode proj for storage.management * Fix dependency paths and project names * Fix assembly name in assembluInfo * Fix KEyVault guid * Add csproj fils for the new common modules to profile * Fix names of csproj files * Netcore projects are case sensitive, and when i changed Keyvault to KeyVault, none of the folder names or file names reflected the change in git... git still sees them as Keyvault * Fix caseing in one more netcore project * Fix casing on the namespace... * Fix the folder name mixup. Step 1 of 2 * Fix the foldername mixup, Step 2 of 2 * Fix project references to point to the correct location * Fix namespace casing in test projet * Fix bad merge * Fix mad merge * Fix project dependencies * As poer feedback, add 2018_04_01 version for compute * Update sevice fabric dependency on the common compute code * Suppress warnings about passwords in generated code. * Credscan can not hanndle secrets in comments.. just removing the offending comments * Fix tests to be able to record them and other small changes * Fix bad merge * Remove UTF8 BOM encoding from file * Fix bad merge in profile psd1 file * Took care of Maddie's comment * iFix assembly name in profile csproj * Add common projects to the stack solution as well

* #1443089: New Powershell commandlets for feature:P2S Ipsec custom policy set on Gateway. and fix build merge errors. * #1443089: Update change log * fix in AzureRM.Network.psd1 * Fix for issue Azure#5365 Moved the Websites dependency of LogicApp into commons * Add websites dll to required assemblies part of Profile * Fic sln files to include the dependencies * Fic dependency paths and projects * Fix dll name * Add/update help files for PS command lets * Incorporate code review comments * Add csproj files for the new common module to Profile * Fix build * Fix dll name (WebSites -> Websites) in the pofile psd1 * Record failing tests * Enabled using network watcher by location * update OutputType in cmdlet * add New-AzureRMNetworkWatcherProtocolConfiguration * fix idictionary issue for header * record network watcher test * [Maps] Rename folders and files from LocationBasedServices * [Maps] Rename help file names * [Maps] Renaming variables, strings, descriptions, etc. * update help docs for New-AzureRmNetworkWatcherProtocolConfiguration * Add -ExtendedProperty parameter to New-AzureService and Set-AzureService cmdlets * Modify Commands.Sql.csproj and Commands.Sql.Test.csproj to use local update Management.Sql.dll binary for now * adding new parameters for create/update elastic pool and database cmdlets. update related db/elastic pool create/update tests * Fix issue in composing PUT request body for database and pool -- Sku object null scenario * Update elasticPool adaptor and communicator to using new sdk when trying to get databases inside a pool (Get-AzureRmSqlElasticPoolDatabase) * Update database replication related models and services to use new autorest sdk (instead of Legacy sdk) to do database copy/secondary, etc. Rerecord all replication related tests * address comments on database/elastic pool cmdlets-- null check, remove commentout codes, etc * address comments. Used -Edition -RequestedServiceObjectiveName for vcore database/pool. Only add new parameter -Vcore to specify vcore number. Modify the database replications, database restore related communicator to use new database webapi * used the published SDK 1.14.0-preview. Update LocationCapabilities model to use new API version (2017 version). Re-record LocationCapability tests * Update all db creation related cmdlets to support vcore database * Update db/elasticpool creation/update tests * Add functions to get skuname when given tier for database and pool, to avoid duplicate codes in cmdlets * use dictionary to mapping tier to skuname * re-record tests and update help file * Update restore cmdlet. Re-recording LTR restore test. Update changeLog. * address comments. and revert all changes related with 'replication links' * using published sdk 1.15.0-preview for the build issue. * Update cmds for creating/updating elasticpool. Use Patch way to do pool update inorder to support correct behaviors for updating pool * fix the yaml trailing issue in help files * Add the removed properties back in DatabaseModel and ElasticPoolModel to avoid breaking changes. And add Edition to BreakingChangeIssue exception * Update BreakingChangeIssues.csv * Address comments. Re-recording part of the failed tests in CI build * re-recording part of the failed tests in CI build. * add new tests records to output dic * link website for New-AzureRmNetworkWatcherProtocolConfiguration.md * re-record backup LTR v2 tests, AuditingClassicStorageTests, ThreatDetectionclassicStorageTests * re-record tests related with ClassicStorage * Fix test TestExportDatabase and re-record it. * fix issue with network watcher md files * Recorded and enabled skipped tests * Add StaticAnalysis checks for - No output type - Optional positional parameters - Parameter set names containing a space - Cmdlets with no default parameter set name and multiple sets * Update BreakingChangeIssues.csv * Record auditing & threat detection tests * Skip severel tests that can only run in live mode (talked with test owner). * Add tests for new static analysis checks * [Maps] Use Maps SDK over LocationBasedServices SDK * Update AzureRM.Network.psd1 * Update New-AzureRmNetworkWatcherProtocolConfiguration.md * make protocol required * Record and enable skipped Brooklyn tests to have test coverage * fix test * move from on demand to regular build * #Fix help file error * address comments. Remove Sku and PerDatabaseSettings from DatabaseModel and ElasticPoolModel.Modify the database and elastic pool response for powershell. * Fix static analysis errors * Update the elastic pool tests. fix bug. * Fix cred scan errors * Fix cred scan errors * Address comments. ReplicationLinkModel, DatabaseCopyModel, remove duplication null check and incorrect help message. * Add dependence in the ServiceManagement sln to fix the sign job * Update SignatureIssues.csv * Add default parameter set for two cmdlets. Update ChangeLog.md and remove unnecessary package files * small type fix * fix breaking change issue and signature issue * Small fix. Use SkuName in the pool model to keep alignment with other models. Rerecord related pool tests * Incorporate code review comments * Updating Networking tests with owner attributes * Fix command output * Revert "Fix command output" This reverts commit a4bace3. * Suppress signature issues as they are approved by Powershell team * Update ChangeLog.md * Update NewAzureNetworkWatcherProtocolConfiguration.cs * Fix to `New-AzureRmAks` help text. * Fix issue with Clear-AzureRmContext where old default context name was being used for empty context * Strategies library: Version 4, new WriteWarning method. * Websites.Strategies are replaced by Common.Strategies library. * Added comments with full team names * update cmdlets based on autorest .net client 2018-01-01 * Refactor InputObject variables and other review comments * get identity properties from InputObject and allow override by parameters * Skip failing Batch tests in on-demand build (see issue Azure#5006) * Update SignatureIssues.csv * Cleanup dependencies and assembly references * remove one more reference * Update modules for 6.1.0 release * Fix error in paths for Profile RequiredAssemblies * Fix for empty examples. * [Maps] Add legacy ResourceManager & update test recordings * [Maps] Add legacy ResourceManager & update test recordings * Add example to Stop-AzureRmResourceGroupDeployment.md * [Maps] Resolving merge revision requests * [Maps] Resolving merge revision requests (2) * Remove spaces in location before comparision * Update Stack.sln * [Maps] Add PassThru to Remove method, resolve build failure * Update azure-powershell-developer-guide.md * [Maps] Update help files to reflect -PassThru param addition * [Maps] Fix trailing yaml string for PassThru * address comments * Fix local build issues because of a netcore sln file introduced accidentally * Update azure-powershell-developer-guide.md * Update test for test-ConnectivityTroubleshoot * Dependency fix : ServiceFabric (Azure#5971) * Fix for Azure#535 Dependency fixes for ServiceFabric in this commit * Add signing stuff and netcode projects to fix netcore build. * Added exception for breaking changes * Update all the sln projects with the newest Keyvault common project * Took care of Cormac's comments * Fix bad merge * Fix breaking build as oer comments from Cormac * Fix file name * Fix sln files for new dependencies * Fix netcore csproj * Fic netcode proj for storage.management * Fix dependency paths and project names * Fix assembly name in assembluInfo * Fix KEyVault guid * Add csproj fils for the new common modules to profile * Fix names of csproj files * Netcore projects are case sensitive, and when i changed Keyvault to KeyVault, none of the folder names or file names reflected the change in git... git still sees them as Keyvault * Fix caseing in one more netcore project * Fix casing on the namespace... * Fix the folder name mixup. Step 1 of 2 * Fix the foldername mixup, Step 2 of 2 * Fix project references to point to the correct location * Fix namespace casing in test projet * Fix bad merge * Fix mad merge * Fix project dependencies * As poer feedback, add 2018_04_01 version for compute * Update sevice fabric dependency on the common compute code * Suppress warnings about passwords in generated code. * Credscan can not hanndle secrets in comments.. just removing the offending comments * Fix tests to be able to record them and other small changes * Fix bad merge * Remove UTF8 BOM encoding from file * Fix bad merge in profile psd1 file * Took care of Maddie's comment * iFix assembly name in profile csproj * Add common projects to the stack solution as well

* #1443089: New Powershell commandlets for feature:P2S Ipsec custom policy set on Gateway. and fix build merge errors. * #1443089: Update change log * fix in AzureRM.Network.psd1 * Fix for issue #5365 Moved the Websites dependency of LogicApp into commons * Add websites dll to required assemblies part of Profile * Fic sln files to include the dependencies * Fic dependency paths and projects * Fix dll name * Add/update help files for PS command lets * Incorporate code review comments * Add csproj files for the new common module to Profile * Fix build * Fix dll name (WebSites -> Websites) in the pofile psd1 * Record failing tests * [Maps] Rename folders and files from LocationBasedServices * [Maps] Rename help file names * [Maps] Renaming variables, strings, descriptions, etc. * Recorded and enabled skipped tests * Add StaticAnalysis checks for - No output type - Optional positional parameters - Parameter set names containing a space - Cmdlets with no default parameter set name and multiple sets * Add tests for new static analysis checks * [Maps] Use Maps SDK over LocationBasedServices SDK * Record and enable skipped Brooklyn tests to have test coverage * fix test * move from on demand to regular build * #Fix help file error * Fix static analysis errors * Fix cred scan errors * Fix cred scan errors * Add dependence in the ServiceManagement sln to fix the sign job * Update SignatureIssues.csv * Incorporate code review comments * Updating Networking tests with owner attributes * Fix command output * Revert "Fix command output" This reverts commit a4bace3. * Suppress signature issues as they are approved by Powershell team * Strategies library: Version 4, new WriteWarning method. * Websites.Strategies are replaced by Common.Strategies library. * Added comments with full team names * Cleanup dependencies and assembly references * remove one more reference * Fix for empty examples. * [Maps] Add legacy ResourceManager & update test recordings * [Maps] Add legacy ResourceManager & update test recordings * Add example to Stop-AzureRmResourceGroupDeployment.md * [Maps] Resolving merge revision requests * [Maps] Resolving merge revision requests (2) * Remove spaces in location before comparision * Revert default role assignment in New-AzureRmADServicePrincipal, update help with examples * Update Stack.sln * [Maps] Add PassThru to Remove method, resolve build failure * Update azure-powershell-developer-guide.md * [Maps] Update help files to reflect -PassThru param addition * [Maps] Fix trailing yaml string for PassThru * address comments * Fix sign job, add tests for service principal creation with role or scope * Fix local build issues because of a netcore sln file introduced accidentally * Update azure-powershell-developer-guide.md * Update test for test-ConnectivityTroubleshoot * Fix AKS doc * Update Get-AzureRmAks.md * Dependency fix : ServiceFabric (#5971) * Fix for #535 Dependency fixes for ServiceFabric in this commit * Add signing stuff and netcode projects to fix netcore build. * Added exception for breaking changes * Update all the sln projects with the newest Keyvault common project * Took care of Cormac's comments * Fix bad merge * Fix breaking build as oer comments from Cormac * Fix file name * Fix sln files for new dependencies * Fix netcore csproj * Fic netcode proj for storage.management * Fix dependency paths and project names * Fix assembly name in assembluInfo * Fix KEyVault guid * Add csproj fils for the new common modules to profile * Fix names of csproj files * Netcore projects are case sensitive, and when i changed Keyvault to KeyVault, none of the folder names or file names reflected the change in git... git still sees them as Keyvault * Fix caseing in one more netcore project * Fix casing on the namespace... * Fix the folder name mixup. Step 1 of 2 * Fix the foldername mixup, Step 2 of 2 * Fix project references to point to the correct location * Fix namespace casing in test projet * Fix bad merge * Fix mad merge * Fix project dependencies * As poer feedback, add 2018_04_01 version for compute * Update sevice fabric dependency on the common compute code * Suppress warnings about passwords in generated code. * Credscan can not hanndle secrets in comments.. just removing the offending comments * Fix tests to be able to record them and other small changes * Fix bad merge * Remove UTF8 BOM encoding from file * Fix bad merge in profile psd1 file * Took care of Maddie's comment * iFix assembly name in profile csproj * Add common projects to the stack solution as well * Fix Issue 5545 - Set Auth Values on UpdateAzureSchedulerServiceBusQueueJobCommand (#6196) * 5545 - Set Auth to value from PSServiceBusAuthenticationParams * Change log updates * Update versions for release of AzureRM.Resources * Fix issue with Properties property of PSResource (#6218) * Fix issue with Properties property of PSResource * Add test coverage for Properties property * Release Maps (#6287) * Update VMSS VM feature (#6170) * Add test coverage for no role assignment in default SP creation scenario * Update AzureRM.psm1 * adding right powershell command Add-AzureApplicationGatewayRequestRoutingRule <-- incorrect Add-AzureRmApplicationGatewayRequestRoutingRule <--corrected command * removing adding space causing powershell error in example $ AppGw is not a valid powershell variable $AppGw has been proposed instead * Typo in powershell command Get-AzureRmApplicationGatewayFrontendIPort is no a valid command Get-AzureRmApplicationGatewayFrontendPort proposed as the corrected powershell command * Fixes inconsistent slot name in example The example and description's slot names should match. * Merging RecoveryServices.Backup code into RecoveryServices (#6263) * Merged RecoveryServices.Backup code in to RecoveryServices * Updating change log * Adding ignored file * Updating test targets and mappings * Moving changelog and documentation files of RS and RS.Backup to their respective module folders * Add ManagementGroups to AzureRM.Resources and Update to use latest SDK for GA (#6271) * Initial migration commit * Move ManagementGroups to AzureRM.Resources * Update powershell to use the latest SDK and API, minor changes to responses and help files * Add installer file * Revert "Add installer file" This reverts commit 0d9b92c. * Update tests and run tests again * Update Help * Update helpfiles * more changes to help files * Changes to Netcore.psd1 * Changes to Netcore.csproj * Update help file * Regenerate all help files * Move help files to AzureRM.Resource help files * Update package version * Update local feed and rerun tests * Remove local feed

* #1443089: New Powershell commandlets for feature:P2S Ipsec custom policy set on Gateway. and fix build merge errors. * #1443089: Update change log * fix in AzureRM.Network.psd1 * Fix for issue Azure#5365 Moved the Websites dependency of LogicApp into commons * Add websites dll to required assemblies part of Profile * Fic sln files to include the dependencies * Fic dependency paths and projects * Fix dll name * Add/update help files for PS command lets * Incorporate code review comments * Add csproj files for the new common module to Profile * Fix build * Fix dll name (WebSites -> Websites) in the pofile psd1 * Record failing tests * Enabled using network watcher by location * update OutputType in cmdlet * add New-AzureRMNetworkWatcherProtocolConfiguration * fix idictionary issue for header * record network watcher test * [Maps] Rename folders and files from LocationBasedServices * [Maps] Rename help file names * [Maps] Renaming variables, strings, descriptions, etc. * update help docs for New-AzureRmNetworkWatcherProtocolConfiguration * Add -ExtendedProperty parameter to New-AzureService and Set-AzureService cmdlets * Modify Commands.Sql.csproj and Commands.Sql.Test.csproj to use local update Management.Sql.dll binary for now * adding new parameters for create/update elastic pool and database cmdlets. update related db/elastic pool create/update tests * Fix issue in composing PUT request body for database and pool -- Sku object null scenario * Update elasticPool adaptor and communicator to using new sdk when trying to get databases inside a pool (Get-AzureRmSqlElasticPoolDatabase) * Update database replication related models and services to use new autorest sdk (instead of Legacy sdk) to do database copy/secondary, etc. Rerecord all replication related tests * address comments on database/elastic pool cmdlets-- null check, remove commentout codes, etc * address comments. Used -Edition -RequestedServiceObjectiveName for vcore database/pool. Only add new parameter -Vcore to specify vcore number. Modify the database replications, database restore related communicator to use new database webapi * used the published SDK 1.14.0-preview. Update LocationCapabilities model to use new API version (2017 version). Re-record LocationCapability tests * Update all db creation related cmdlets to support vcore database * Update db/elasticpool creation/update tests * Add functions to get skuname when given tier for database and pool, to avoid duplicate codes in cmdlets * use dictionary to mapping tier to skuname * re-record tests and update help file * Update restore cmdlet. Re-recording LTR restore test. Update changeLog. * address comments. and revert all changes related with 'replication links' * using published sdk 1.15.0-preview for the build issue. * Update cmds for creating/updating elasticpool. Use Patch way to do pool update inorder to support correct behaviors for updating pool * fix the yaml trailing issue in help files * Add the removed properties back in DatabaseModel and ElasticPoolModel to avoid breaking changes. And add Edition to BreakingChangeIssue exception * Update BreakingChangeIssues.csv * Address comments. Re-recording part of the failed tests in CI build * re-recording part of the failed tests in CI build. * add new tests records to output dic * link website for New-AzureRmNetworkWatcherProtocolConfiguration.md * re-record backup LTR v2 tests, AuditingClassicStorageTests, ThreatDetectionclassicStorageTests * re-record tests related with ClassicStorage * Fix test TestExportDatabase and re-record it. * fix issue with network watcher md files * Recorded and enabled skipped tests * Add StaticAnalysis checks for - No output type - Optional positional parameters - Parameter set names containing a space - Cmdlets with no default parameter set name and multiple sets * Update BreakingChangeIssues.csv * Record auditing & threat detection tests * Skip severel tests that can only run in live mode (talked with test owner). * Add tests for new static analysis checks * [Maps] Use Maps SDK over LocationBasedServices SDK * Update AzureRM.Network.psd1 * Update New-AzureRmNetworkWatcherProtocolConfiguration.md * make protocol required * Record and enable skipped Brooklyn tests to have test coverage * fix test * move from on demand to regular build * #Fix help file error * address comments. Remove Sku and PerDatabaseSettings from DatabaseModel and ElasticPoolModel.Modify the database and elastic pool response for powershell. * Fix static analysis errors * Update the elastic pool tests. fix bug. * Fix cred scan errors * Fix cred scan errors * Address comments. ReplicationLinkModel, DatabaseCopyModel, remove duplication null check and incorrect help message. * Add dependence in the ServiceManagement sln to fix the sign job * Update SignatureIssues.csv * Add default parameter set for two cmdlets. Update ChangeLog.md and remove unnecessary package files * small type fix * fix breaking change issue and signature issue * Small fix. Use SkuName in the pool model to keep alignment with other models. Rerecord related pool tests * Incorporate code review comments * Updating Networking tests with owner attributes * Fix command output * Revert "Fix command output" This reverts commit a4bace3. * Suppress signature issues as they are approved by Powershell team * Update ChangeLog.md * Update NewAzureNetworkWatcherProtocolConfiguration.cs * Fix to `New-AzureRmAks` help text. * Fix issue with Clear-AzureRmContext where old default context name was being used for empty context * Strategies library: Version 4, new WriteWarning method. * Websites.Strategies are replaced by Common.Strategies library. * Added comments with full team names * update cmdlets based on autorest .net client 2018-01-01 * Refactor InputObject variables and other review comments * get identity properties from InputObject and allow override by parameters * Skip failing Batch tests in on-demand build (see issue Azure#5006) * Update SignatureIssues.csv * Cleanup dependencies and assembly references * remove one more reference * Update modules for 6.1.0 release * Fix error in paths for Profile RequiredAssemblies * Fix for empty examples. * [Maps] Add legacy ResourceManager & update test recordings * [Maps] Add legacy ResourceManager & update test recordings * Add example to Stop-AzureRmResourceGroupDeployment.md * [Maps] Resolving merge revision requests * [Maps] Resolving merge revision requests (2) * Remove spaces in location before comparision * Update Stack.sln * [Maps] Add PassThru to Remove method, resolve build failure * Update azure-powershell-developer-guide.md * [Maps] Update help files to reflect -PassThru param addition * [Maps] Fix trailing yaml string for PassThru * address comments * Fix local build issues because of a netcore sln file introduced accidentally * Update azure-powershell-developer-guide.md * Update test for test-ConnectivityTroubleshoot * Dependency fix : ServiceFabric (Azure#5971) * Fix for Azure#535 Dependency fixes for ServiceFabric in this commit * Add signing stuff and netcode projects to fix netcore build. * Added exception for breaking changes * Update all the sln projects with the newest Keyvault common project * Took care of Cormac's comments * Fix bad merge * Fix breaking build as oer comments from Cormac * Fix file name * Fix sln files for new dependencies * Fix netcore csproj * Fic netcode proj for storage.management * Fix dependency paths and project names * Fix assembly name in assembluInfo * Fix KEyVault guid * Add csproj fils for the new common modules to profile * Fix names of csproj files * Netcore projects are case sensitive, and when i changed Keyvault to KeyVault, none of the folder names or file names reflected the change in git... git still sees them as Keyvault * Fix caseing in one more netcore project * Fix casing on the namespace... * Fix the folder name mixup. Step 1 of 2 * Fix the foldername mixup, Step 2 of 2 * Fix project references to point to the correct location * Fix namespace casing in test projet * Fix bad merge * Fix mad merge * Fix project dependencies * As poer feedback, add 2018_04_01 version for compute * Update sevice fabric dependency on the common compute code * Suppress warnings about passwords in generated code. * Credscan can not hanndle secrets in comments.. just removing the offending comments * Fix tests to be able to record them and other small changes * Fix bad merge * Remove UTF8 BOM encoding from file * Fix bad merge in profile psd1 file * Took care of Maddie's comment * iFix assembly name in profile csproj * Add common projects to the stack solution as well

praries880 added 2 commits April 17, 2018 10:38

Fix for Azure#535

1e60f64

Dependency fixes for ServiceFabric in this commit

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

e383491

…nto dependency_fix

praries880 assigned cormacpayne Apr 17, 2018

praries880 added the needs-review label Apr 17, 2018

Add signing stuff and netcode projects to fix netcore build.

ff2a0df

cormacpayne previously requested changes Apr 18, 2018

View reviewed changes

cormacpayne added needs-revision and removed needs-review labels Apr 18, 2018

cormacpayne assigned praries880 and unassigned cormacpayne Apr 18, 2018

praries880 added 5 commits April 18, 2018 11:55

Added exception for breaking changes

e534f9a

Update all the sln projects with the newest Keyvault common project

ae9334a

Took care of Cormac's comments

2c20260

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

7144b23

…nto dependency_fix

Fix bad merge

e8acca5

cormacpayne reviewed Apr 19, 2018

View reviewed changes

praries880 added 3 commits April 19, 2018 16:04

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

546c2b9

…nto dependency_fix

Fix breaking build as oer comments from Cormac

1699425

Fix file name

ee3322d

cormacpayne reviewed Apr 19, 2018

View reviewed changes

praries880 added 6 commits April 20, 2018 11:55

Fix sln files for new dependencies

0dd4ec1

Fix netcore csproj

f126506

Fic netcode proj for storage.management

5e8a65e

Fix dependency paths and project names

2a38315

Fix assembly name in assembluInfo

03a6217

Fix KEyVault guid

ca8cdef

maddieclayton assigned cormacpayne and maddieclayton and unassigned juhacket and praries880 May 22, 2018

maddieclayton added needs-review and removed needs-revision labels May 22, 2018

Took care of Maddie's comment

1202db4

praries880 dismissed juhacket’s stale review via 1202db4 May 23, 2018 00:27

maddieclayton previously approved these changes May 23, 2018

View reviewed changes

maddieclayton added Waiting for CI and removed needs-review labels May 23, 2018

iFix assembly name in profile csproj

45c86a1

praries880 dismissed maddieclayton’s stale review via 45c86a1 May 23, 2018 15:17

Add common projects to the stack solution as well

b23d50d

praries880 and others added 2 commits May 23, 2018 15:02

Merge branch 'preview' into dependency_fix

e59f115

Merge branch 'preview' of https://github.com/Azure/azure-powershell i…

df28f92

…nto dependency_fix

cormacpayne approved these changes May 23, 2018

View reviewed changes

cormacpayne unassigned cormacpayne and maddieclayton May 23, 2018

maddieclayton merged commit 490dbac into Azure:preview May 24, 2018

praries880 deleted the dependency_fix branch May 24, 2018 16:46

Dependency fix : ServiceFabric #5971

Dependency fix : ServiceFabric #5971

Uh oh!

Conversation

praries880 commented Apr 17, 2018

Uh oh!

praries880 commented Apr 17, 2018

Uh oh!

praries880 commented Apr 17, 2018

Uh oh!

cormacpayne left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cormacpayne commented Apr 19, 2018

Uh oh!

praries880 commented Apr 19, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maddieclayton commented May 23, 2018

Uh oh!

praries880 commented May 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

praries880 commented May 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cormacpayne commented May 23, 2018

Uh oh!

praries880 commented May 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

praries880 commented May 23, 2018 •

edited

Loading

praries880 commented May 23, 2018 •

edited

Loading