-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Ledger Digest Upload SDK #21021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Ledger Digest Upload SDK #21021
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
0ef2c1f
adding ledger changes
rewongmicrosoft 55da900
all generated changes
rewongmicrosoft 601c176
adding ledger changes
rewongmicrosoft 67a4160
all generated changes
rewongmicrosoft cef5408
Merge branch 'rewong_ledger' of https://github.com/rewongmicrosoft/az…
rewongmicrosoft 5ac0d05
generated files updates
rewongmicrosoft a16dc65
adding tests, new generated files from databases
rewongmicrosoft ea1a66b
updating recorded tests for ledger
rewongmicrosoft 1b07418
renaming file path
rewongmicrosoft 68acf2a
adding ListByServerWithHttpMessagesAsync to database operations custo…
rewongmicrosoft aa5cf86
fixing newline spacing
rewongmicrosoft d25baaa
upating based on most recent generation
rewongmicrosoft 4c383d0
adding sql_resource-manager.txt file
rewongmicrosoft 201dd45
final updates to ListByServerWithHttpMessagesAsync interface and caller
rewongmicrosoft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,12 +3,13 @@ AutoRest installed successfully. | |
| Commencing code generation | ||
| Generating CSharp code | ||
| Executing AutoRest command | ||
| cmd.exe /c autorest.cmd https://github.com/Azure/azure-rest-api-specs/blob/master/specification/sql/resource-manager/readme.md --csharp --version=v2 --reflect-api-versions --csharp-sdks-folder=D:\azure-sdk-for-net\sdk | ||
| 2021-05-07 22:38:44 UTC | ||
| cmd.exe /c autorest.cmd https://github.com/Azure/azure-rest-api-specs/blob/master/specification/sql/resource-manager/readme.md --csharp --version=v2 --reflect-api-versions --csharp-sdks-folder=C:\azure-sdk-for-net\sdk | ||
| Autorest CSharp Version: 2.3.82 | ||
| 2021-05-13 18:14:30 UTC | ||
| Azure-rest-api-specs repository information | ||
| GitHub fork: Azure | ||
| Branch: master | ||
| Commit: a4924d479f80242b6bd5d02328c4579f58dc87da | ||
| Commit: 7d4caa5e1c9996a25300b0b23ef426667e4a7bde | ||
| AutoRest information | ||
| Requested version: v2 | ||
| Bootstrapper version: [email protected] | ||
2 changes: 1 addition & 1 deletion
2
sdk/sqlmanagement/Microsoft.Azure.Management.Sql/AzSdk.RP.props
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| <Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <!--This file and it's contents are updated at build time moving or editing might result in build failure. Take due deligence while editing this file--> | ||
| <PropertyGroup> | ||
| <AzureApiTag>Sql_2017-10-01-preview;Sql_2020-08-01-preview;Sql_2014-04-01;Sql_2015-05-01-preview;Sql_2017-03-01-preview;Sql_2020-02-02-preview;Sql_2020-11-01-preview;Sql_2018-06-01-preview;Sql_2019-06-01-preview;</AzureApiTag> | ||
| <AzureApiTag>Sql_2020-11-01-preview;Sql_2014-04-01;Sql_2021-02-01-preview;</AzureApiTag> | ||
| <PackageTags>$(PackageTags);$(CommonTags);$(AzureApiTag);</PackageTags> | ||
| </PropertyGroup> | ||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
...qlmanagement/Microsoft.Azure.Management.Sql/src/Generated/DatabaseExtensionsOperations.cs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
4 changes: 2 additions & 2 deletions
4
sdk/sqlmanagement/Microsoft.Azure.Management.Sql/src/Generated/DatabaseOperations.cs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
2 changes: 1 addition & 1 deletion
2
sdk/sqlmanagement/Microsoft.Azure.Management.Sql/src/Generated/DatabaseUsagesOperations.cs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mostly looks good. To completely disambiguate the method calls, the customeHeadres parameter should not have a default value - this way, any call that uses 2 string parameters will go to the new method , you would need similar customizations in the partial interface for IDatabasesOperations and the ListByServerAsync method in the DatabasesOperationsExtensions partial class [although, since this is an extension method, it doden't need to reside in the same static class]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok I understand now. Made the changes to add the interface in IDatabasesOperations, and add ListByServerAsync without skip token in the DatabasesOperationsExtensions class