Skip to content

Remove a bit of Python 2.7 code #38735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Dec 20, 2024
Merged

Remove a bit of Python 2.7 code #38735

merged 17 commits into from
Dec 20, 2024

Conversation

@atombrella
Copy link
Contributor

@atombrella atombrella commented Dec 1, 2024

Description

Note that this is just a small portion of the Python 2.7 that's still left around in the code base.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Event Hubs KeyVault Machine Learning Service Bus Storage Storage Service (Queues, Blobs, Files) labels Dec 1, 2024
@github-actions
Copy link

github-actions bot commented Dec 1, 2024

Thank you for your contribution @atombrella! We will review the pull request and get back to you soon.

swathipil
swathipil approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@swathipil swathipil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for eventhub and servicebus - thanks @atombrella!

@scbedd
Copy link
Member

scbedd commented Dec 11, 2024

/azp run python - pullrequest

@azure-pipelines
Copy link

azure-pipelines bot commented Dec 11, 2024

Azure Pipelines successfully started running 1 pipeline(s).

mccoyp
mccoyp approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Key Vault changes look good, but we'll need to sort out the Storage changes before merging, per Jacob's comment.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Dec 20, 2024

API change check

API changes are not detected in this pull request.

@atombrella
Copy link
Contributor Author

atombrella commented Dec 20, 2024

@kristapratico @lmazuel @swathipil I think this is fine for now. I don't know what causes the test failures on MacOS, but it seems unrelated.

@kristapratico
Copy link
Contributor

kristapratico commented Dec 20, 2024

@kristapratico @lmazuel @swathipil I think this is fine for now. I don't know what causes the test failures on MacOS, but it seems unrelated.

Looks like a transient error, I re-ran it and it resolved. Thanks for updating the PR!

@jalauzon-msft can you re-review the storage changes and sign off if you're good with it?

jalauzon-msft
jalauzon-msft approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@jalauzon-msft jalauzon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for Storage, thanks!

kristapratico
kristapratico approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDK tools CI failure is unrelated

@kristapratico kristapratico merged commit bf50574 into Azure:main Dec 20, 2024
36 of 37 checks passed
@atombrella atombrella deleted the python2_7_unicode branch December 21, 2024 16:54
singankit pushed a commit that referenced this pull request Jan 14, 2025
@atombrella @singankit
Remove a bit of Python 2.7 code (#38735)
b83e9b6 
* Remove a bit of Python 2.7 code

* Fix typo

* Remove _str consistently

* More replacements

* fix mock

* fix

* reset stuff

* Reset changes in legacy servicemanagement

* fix _str

* fix

* pylint

---------

Co-authored-by: Mads Jensen <[email protected]>
l0lawrence pushed a commit to l0lawrence/azure-sdk-for-python that referenced this pull request Feb 19, 2025
@atombrella @l0lawrence
Remove a bit of Python 2.7 code (Azure#38735)
ccb9c90 
* Remove a bit of Python 2.7 code

* Fix typo

* Remove _str consistently

* More replacements

* fix mock

* fix

* reset stuff

* Reset changes in legacy servicemanagement

* fix _str

* fix

* pylint

---------

Co-authored-by: Mads Jensen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmazuel lmazuel lmazuel left review comments

@swathipil swathipil swathipil approved these changes

@kashifkhan kashifkhan kashifkhan approved these changes

@mccoyp mccoyp mccoyp approved these changes

@jalauzon-msft jalauzon-msft jalauzon-msft approved these changes

@scbedd scbedd Awaiting requested review from scbedd scbedd is a code owner

@annatisch annatisch Awaiting requested review from annatisch annatisch is a code owner

@l0lawrence l0lawrence Awaiting requested review from l0lawrence

@paulshealy1 paulshealy1 Awaiting requested review from paulshealy1 paulshealy1 is a code owner

@achauhan-scc achauhan-scc Awaiting requested review from achauhan-scc achauhan-scc is a code owner

@kingernupur kingernupur Awaiting requested review from kingernupur kingernupur is a code owner

@jayesh-tanna jayesh-tanna Awaiting requested review from jayesh-tanna jayesh-tanna is a code owner

@vincenttran-msft vincenttran-msft Awaiting requested review from vincenttran-msft vincenttran-msft is a code owner

@weirongw23-msft weirongw23-msft Awaiting requested review from weirongw23-msft weirongw23-msft is a code owner

@johanste johanste Awaiting requested review from johanste

+1 more reviewer

@kristapratico kristapratico kristapratico approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Event Hubs KeyVault Machine Learning Service Bus Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@atombrella @scbedd @azure-sdk @kristapratico @kashifkhan @lmazuel @mccoyp @swathipil @jalauzon-msft