Skip to content

enum fix for ktx/basis #16900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025
Merged

enum fix for ktx/basis #16900

merged 1 commit into from
Jul 18, 2025

Conversation

CedricGuillemet
Copy link
Contributor

while investigating

https://forum.babylonjs.com/t/ktx2-ios-mipmap-issue/59136

Found an issue here:

const targetFormat = basisModule.TranscodeTarget[KTX2.TranscodeTarget[dst]]; // works because the labels of the sourceTextureFormat enum are the same as the property names used in TranscodeTarget!

To make it short, KTX2.TranscodeTarget[dst] returned ASTC_4X4_RGBA while expected value for basis is ASTC_4x4_RGBA. Keeping old enum value to not break back compat.

@CedricGuillemet CedricGuillemet requested a review from bghgary July 18, 2025 13:04
@bjsplat
Copy link
Collaborator

bjsplat commented Jul 18, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 18, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 18, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 18, 2025

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so sneaky... it took me ages to get it :-)

@sebavan sebavan merged commit f6c958f into master Jul 18, 2025
18 checks passed
@sebavan sebavan deleted the ktxtest branch July 18, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants