glTF Exporter: Handle unsupported encode formats at platform level #17366
Conversation
…n encoding glTF images (and give _getImageDataAsync a purpose again!)
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17366/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17366/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17366/merge#BCU1XR#0 |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
|
Devhost visualization test reporter: |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
1 similar comment
|
WebGL2 visualization test reporter: |
Pull request was converted to draft
|
Closing to merge into #17365. |
3 participants
This PR addresses cases where exporting images to a specific format could lead to invalid images if the browser or platform didn't support it. It is enabled by a change in #17365 (TBD), whereby a mismatch in requested vs. actual mime type now rejects the promise.
image/pngMIME type. (PNG is the minimum requirement for platforms implementing image encoding)To achieve this, the internal
getImageDataAsyncfunction is now the source of truth for an image's MIME type. It treats themimeTypeparameter as a suggestion and returns the image data along with its actual final format. This ensures that if a fallback occurs at this step, the rest of the export pipeline uses the correct type.