You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates all MAZ data references in tm2py-utils to the landuse_file parameter from the scenario configs, removes redundant/unused methods that referenced the outdated MAZ input, and fixes minor bugs in the transit summaries.
The reason will be displayed to describe this comment to others. Learn more.
@lmz, @Ennazus, not sure we should convert boarding nodes to strings here. My i_node/j_node come in as numeric. Converting to str makes access_df empty. What dtypes are you seeing locally? If this is a version issue on my side.
@lmz@Ennazus, I’ve completed the review and update of the MAZ data reference in tm2py-utils. Many of the zone-related issues I saw previously are now addressed by your recent commits—thank you! The final change is to remove the maz_landuse_file parameter entirely from scenario_config.toml. Could you please point me to where your scenario_config.toml is saved?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates all MAZ data references in
tm2py-utilsto thelanduse_fileparameter from the scenario configs, removes redundant/unused methods that referenced the outdated MAZ input, and fixes minor bugs in the transit summaries.