[Fix] Router: optimize provider tracking in _set_model_group_info (O(n*p) → O(n)) #15107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace O(n×p) list-based provider deduplication with O(n) set-based approach in _set_model_group_info(). Previously, the function checked `if llm_provider not in providers` on each iteration, resulting in O(p) list scans per model. Changes: - Track providers in a set during iteration for O(1) deduplication - Convert set to list after loop to maintain API contract - Reduces time complexity from O(n×p) to O(n) Impact: Improves performance for /model_group/info endpoint (which iterates over all models without caching) and on LRU cache misses for set_response_headers.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
AlexsanderHamir
force-pushed
the
litellm_router_cleaning_5
branch
from
ce04ebb to
47c83a4
Compare
AlexsanderHamir
commented
Oct 1, 2025
| ): | ||
| model_group_info.supports_url_context = True | ||
|
|
||
| # Track provider in set for O(1) deduplication |
There was a problem hiding this comment.
Most changes are just indentation from removal of if statement.
Actual Changes:
- Use set for deduplication
- Add providers at the end
AlexsanderHamir
commented
Oct 1, 2025
| cast, | ||
| ) | ||
|
|
||
| from fastapi import HTTPException |
There was a problem hiding this comment.
doc quality pointed this was missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
[Fix] Router: optimize provider tracking in _set_model_group_info (O(n*p) → O(n))
Relevant issues
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
tests/litellm/directory, Adding at least 1 test is a hard requirement - see detailsmake test-unitType
🧹 Refactoring
Changes
Performance Gains