Frontend refactor to typescript #3605
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IdPrefix is not relly neeeded, however many components that use PasswordSingleInput or PasswordRepeatInput are untyped BitBox01 components. To be safe it would be better to convert to TypeScript.
Moving first to have a nicer diff in next commit.
Moving first to have a nicer diff in the next commit.
The errorCode state was not used, instead it just shows an alert
message with either bitbox.error.e${data.code} or just the error.
Moving first to have a nicer diff in the next commit.
Moving first to have a nicer diff in the next commit.
Moving first to have a nicer diff in the next commit.
Mostly by just running make webfix
Moving first to have a nicer diff in the next commit.
Moving first to have a nicer diff in the next commit.
If BB01 password is too short the app used to display an error. Added the too short error back.
thisconnect
force-pushed
the
frontend-refactor-to-typescript
branch
from
7c2c433 to
cfc7aa8
Compare
|
rebased, to test PR #3604 with typed BB01 components |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental branch to check for typescript issues in PR #3604
As a test all components that import from password.tsx have been converted to typescript to check for errors.
Some small issues surfaced and were fixed in this branch (see last commit)