Skip to content

Conversation

bznein
Copy link
Collaborator

@bznein bznein commented Oct 9, 2025

These are the watch-only tests that we usually run manually. However the ones that require the use of the passphrase are not implemented yet as they need changes to the simulator.

Before asking for reviews, here is a check list of the most common things you might need to consider:

  • updating the Changelog
  • writing unit tests
  • checking if your changes affect other coins or tokens in unintended ways
  • testing on multiple environments (Qt, Android, ...)
  • having an AI review your changes

@bznein bznein requested a review from thisconnect October 9, 2025 12:45
@bznein bznein force-pushed the playwrightTests branch 4 times, most recently from ed15dc4 to 09d197a Compare October 9, 2025 15:32
@bznein bznein mentioned this pull request Oct 16, 2025
5 tasks
Tests need the simulator, so we checkout the firmware repo, build the
simulator, upload the artifact, and then we download it and use it in
the test.
@bznein bznein requested a review from thisconnect October 20, 2025 10:57
Copy link
Collaborator

@thisconnect thisconnect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested LGTM

@bznein bznein merged commit 852de7c into BitBoxSwiss:master Oct 20, 2025
31 of 34 checks passed
@bznein bznein deleted the playwrightTests branch October 20, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants