Support building with libsasl2

.travis.yml

@@ -4,6 +4,9 @@ sudo: required
 node_js:
 - '4'
 - '6'
+env:
+- WITH_SASL=0
+- WITH_SASL=1
 cache:
   directories:
   - node_modules

README.md

@@ -40,7 +40,7 @@ This project includes two types of unit tests in this project:
 
 You can run both types of tests by using `Makefile`. Doing so calls `mocha` in your locally installed `node_modules` directory.
 
-* Before you run the tests, be sure to init and update the submodules: 
+* Before you run the tests, be sure to init and update the submodules:
   1. `git submodule init`
   2. `git submodule update`
 * To run the unit tests, you can run `make lint` or `make test`.
@@ -62,7 +62,7 @@ var Kafka = require('node-rdkafka');
 
 ## Configuration
 
-You can pass many configuration options to `librdkafka`.  A full list can be found in `librdkafka`'s [Configuration.md](https://github.com/edenhill/librdkafka/blob/2213fb29f98a7a73f22da21ef85e0783f6fd67c4/CONFIGURATION.md) 
+You can pass many configuration options to `librdkafka`.  A full list can be found in `librdkafka`'s [Configuration.md](https://github.com/edenhill/librdkafka/blob/2213fb29f98a7a73f22da21ef85e0783f6fd67c4/CONFIGURATION.md)
 
 Configuration keys that have the suffix `_cb` are designated as callbacks. Some
 of these keys are informational and you can choose to opt-in (for example, `dr_cb`). Others are callbacks designed to
@@ -76,6 +76,13 @@ The library currently supports the following callbacks:
 * `dr_cb`
 * `event_cb`
 
+### SASL Support
+
+`librdkafka` supports using SASL for authentication and `node-rdkafka` has it turned on by default. If you would like
+disable `sasl` support, export `WITH_SASL=0` before you run `npm install`. (You can also specify it when using `node-gyp`, `node-gyp --WITH_SASL=0 rebuild`)
+
+This means you are required to have `libsasl2` on the machine before you build it.
+
 ## Sending Messages
 
 A `Producer` sends messages to Kafka.  The `Producer` constructor takes a configuration object, as shown in the following example:

binding.gyp

@@ -2,6 +2,7 @@
   "variables": {
       # may be redefined in command line on configuration stage
       "BUILD_LIBRDKAFKA%": "<!(echo ${BUILD_LIBRDKAFKA:-1})",
+      "WITH_SASL%": "<!(echo ${WITH_SASL:-1})"
   },
   "targets": [
     {
@@ -11,6 +12,7 @@
         "<!(node -e \"require('nan')\")",
         "<(module_root_dir)/"
       ],
+      "libraries" : ['-lsasl2'],
       'conditions': [
         [ "<(BUILD_LIBRDKAFKA)==1",
             {
@@ -62,6 +64,20 @@
             },
           }
         ],
+        [ "<(WITH_SASL)==1",
+          {
+            'libraries' : ['-lsasl2'],
+            'conditions': [
+              [ 'OS=="mac"',
+                {
+                  'xcode_settings': {
+                    'libraries' : ['-lsasl2']
+                  }
+                }
+              ],
+            ]
+          }
+        ]
       ]
     }
   ]

deps/librdkafka.gyp

@@ -1,4 +1,7 @@
 {
+  'variables': {
+    "WITH_SASL%": "<!(echo ${WITH_SASL:-1})"
+  },
   'targets': [
     {
       "target_name": "librdkafka_cpp",
@@ -123,6 +126,13 @@
               }
             },
           }
+        ],
+        [ "<(WITH_SASL)==1",
+          {
+            'sources': [
+              'librdkafka/src/rdkafka_sasl.c'
+            ]
+          }
         ]
       ],
       'sources': [
@@ -171,14 +181,22 @@
             'librdkafka/config.h',
           ],
           "conditions": [
-            [
-                'OS!="win"',
-                {
-                  'action': ['eval', 'cd librdkafka && chmod a+x ./configure && ./configure --disable-sasl']
-                },
-                {
-                  'action': ['echo']
-                }
+            [ 'OS!="win"',
+              {
+                "conditions": [
+                  [ "<(WITH_SASL)==1",
+                    {
+                      'action': ['eval', 'cd librdkafka && chmod a+x ./configure && ./configure']
+                    },
+                    {
+                      'action': ['eval', 'cd librdkafka && chmod a+x ./configure && ./configure --disable-sasl']
+                    }
+                  ]
+                ]
+              },
+              {
+                'action': ['echo']
+              }
             ]
           ]
         }