Skip to content

Added stopping() signal to qt::QuickRenderer for GL cleanup operations #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2017
Merged

Added stopping() signal to qt::QuickRenderer for GL cleanup operations #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions deflect/qt/QuickRenderer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,8 @@ void QuickRenderer::_onStop()
if (_context)
_context->makeCurrent(_getSurface());

emit stopping();

_renderControl.invalidate();

_fbo.reset();
Expand Down
6 changes: 6 additions & 0 deletions deflect/qt/QuickRenderer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,12 @@ class QuickRenderer : public QObject
*/
void afterRender();

/**
* Emitted from the render thread during stop(). Can be used to do some last
* cleanup operations while the GL context is bound.
*/
void stopping();

private:
QQuickWindow& _quickWindow;
QQuickRenderControl& _renderControl;
Expand Down
2 changes: 2 additions & 0 deletions doc/Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ Changelog {#Changelog}

### 0.14.0 (git master)

* [179](https://github.com/BlueBrain/Deflect/pull/179):
Added stopping() signal to qt::QuickRenderer for GL cleanup operations.
* [177](https://github.com/BlueBrain/Deflect/pull/177):
Improve stream error handling
* Catch errors regarding invalid JPEG quality values
Expand Down