Fixed unit test deadlock due to incorrect execption handling #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug was introduced in BlueBrain#177 and could result in the global QThreadPool threads being locked forever.
dnachbaur
approved these changes
Aug 30, 2017
Author
|
damn, still not fixed..! |
Author
|
retest this please |
Author
|
I'm merging because it already improves the situation (and #180 refuses to build without this). But the previous failure should not be ignored: https://bbpcode.epfl.ch/ci/job/oss.Deflect.github/405/build_type=Release,platform=cscsviz-vm/console |
Author
|
for the record, the remaining test failures are mostly due to concurrent calls to BOOST_CHECK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was introduced in #177 and could result in the global QThreadPool threads being locked forever.