-
Notifications
You must be signed in to change notification settings - Fork 16
Add address bar to the Webbrowser [DISCL-380] #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| //@} | ||
|
|
||
| /** @name Mouse gesture handlers. */ | ||
| /** @name Keyboard gesture handlers. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keyboard has gestures??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha :-)
|
Adding a test of the webbrowser serialization and the RESTServer? |
|
Done, with additonal cleanups |
|
|
||
| int RestServer::getPort() const | ||
| { | ||
| return _httpServer.getURI().getPort(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not only getPort()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing any such method, I think it has to be retrieved from he uri...
|
+2 otherwise. Good job! |
needs BlueBrain/Deflect#119