Skip to content

Conversation

@rdumusc
Copy link

@rdumusc rdumusc commented Aug 9, 2016

//@}

/** @name Mouse gesture handlers. */
/** @name Keyboard gesture handlers. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keyboard has gestures??

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha :-)

@dnachbaur
Copy link
Contributor

Adding a test of the webbrowser serialization and the RESTServer?

@rdumusc
Copy link
Author

rdumusc commented Aug 10, 2016

Done, with additonal cleanups


int RestServer::getPort() const
{
return _httpServer.getURI().getPort();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not only getPort()?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing any such method, I think it has to be retrieved from he uri...

@dnachbaur
Copy link
Contributor

+2 otherwise. Good job!

@rdumusc rdumusc merged commit 53c30af into BlueBrain:master Aug 10, 2016
@rdumusc rdumusc deleted the history branch August 10, 2016 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants