Skip to content

Fix: 3099 #3106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2025
Merged

Fix: 3099 #3106

merged 1 commit into from
Jul 13, 2025

Conversation

BornToBeRoot
Copy link
Owner

Changes proposed in this pull request

  • Add icons for dialog

Related issue(s)

Copilot generated summary

Provide a Copilot generated summary of the changes in this pull request.

Copilot summary

This pull request introduces a new feature to enhance the customization of child window icons in the NETworkManager application. It adds support for dynamically setting the icon style based on the context (e.g., Info, Warn, Error) and updates the UI components accordingly. Additionally, there are minor visual adjustments to the tooltip design.

New Feature: Dynamic Child Window Icons

  • New Enum for Icon Types: Added ChildWindowIcon enum to define icon types (Info, Warn, Error) for child dialogs (Source/NETworkManager.Utilities/ChildWindowIcon.cs).
  • Converter for Icon Styles: Implemented ChildWindowIconToRectangleStyleConverter to map ChildWindowIcon values to corresponding rectangle styles (Source/NETworkManager.Converters/ChildWindowIconToRectangleStyleConverter.cs).
  • ViewModel Update: Extended OKMessageViewModel to include an Icon property, allowing the icon type to be passed during initialization (Source/NETworkManager/ViewModels/OKMessageViewModel.cs). [1] [2]
  • UI Integration: Updated OKMessageChildWindow.xaml to use the new converter for dynamically applying icon styles (Source/NETworkManager/Views/OKMessageChildWindow.xaml). [1] [2] [3]

Minor Visual Update

  • Tooltip Color Adjustment: Changed the tooltip corner fill color to a custom hex value (#b95353) for improved visual consistency (Source/NETworkManager/Resources/Templates/ValidationErrorTemplates.xaml).

Contributing

By submitting this pull request, I confirm the following:

@BornToBeRoot BornToBeRoot added this to the next-release milestone Jul 13, 2025
@mergify mergify bot merged commit 4769fcd into main Jul 13, 2025
4 checks passed
@mergify mergify bot deleted the feature/3099 branch July 13, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OKMessageChildWindow replace icon with info, error, warning
1 participant